Bug 339098 - JJ: Overhaul KNotify notification events to use more descriptive event titles
Summary: JJ: Overhaul KNotify notification events to use more descriptive event titles
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: notifications (show other bugs)
Version: frameworks
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 337512
  Show dependency treegraph
 
Reported: 2014-09-15 15:35 UTC by Eike Hein
Modified: 2014-11-30 14:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-09-15 15:35:02 UTC
Konversation's KNotify notification events currently use the event name from the config as notification title. It would be nicer to explicitly pass a more useful, dynamic title, e.g. "<name> mentioned you in <channel>" instead of the generic "Someone mentioned your nick".

This would improve the user experience when running under Plasma Desktop 5, where consecutive notification events with identical titles are merged into a single notification, making it impossible to e.g. tell apart two pings from different channels in the notifications.
Comment 1 Eike Hein 2014-11-30 14:58:43 UTC
Git commit 900baea903d839e6f007293c07eef51856b6c78f by Eike Hein, on behalf of eli mackenzie.
Committed on 30/11/2014 at 14:57.
Pushed by hein into branch '1.6'.

Override event description with non-generic notification titles.

This prevents Plasma Desktop 5 from merging notification events
from different sources (channel/nick).

M  +22   -10   src/notificationhandler.cpp

http://commits.kde.org/konversation/900baea903d839e6f007293c07eef51856b6c78f