Bug 339063 - Tellico crashes on 'Update Entry -> ISBNdb.com' if title starts with 'Pixi'
Summary: Tellico crashes on 'Update Entry -> ISBNdb.com' if title starts with 'Pixi'
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 2.3.8
Platform: Kubuntu Linux
: NOR crash
Target Milestone: ---
Assignee: Robby Stephenson
Depends on:
Reported: 2014-09-14 09:40 UTC by Dirk Sarpe
Modified: 2014-10-11 23:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.3.10


Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Sarpe 2014-09-14 09:40:37 UTC
Tellico crashes on 'Update Entry -> ISBNdb.com' if title starts with 'Pixi'. I tried several titles containing phrases with 'Pixi'. If the title starts with it then Tellico crashes. Titles like 'Pix' or 'ixi' alone do not crash Tellico.

Exact package version is
  Installiert:           2.3.8+dfsg.1-2.1~ubuntu14.04~ppa1
  Installationskandidat: 2.3.8+dfsg.1-2.1~ubuntu14.04~ppa1
 *** 2.3.8+dfsg.1-2.1~ubuntu14.04~ppa1 0
        500 http://ppa.launchpad.net/kubuntu-ppa/backports/ubuntu/ trusty/main amd64 Packages

Unfortunately there are no debugging symbols packaged for Kubuntu so the backtrace might be useless:

Application: Tellico (tellico), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f72223f6800 (LWP 18067))]

Thread 2 (Thread 0x7f720564b700 (LWP 18071)):
#0  0x00007f721b80bc6d in poll () at ../sysdeps/unix/syscall-template.S:81
#1  0x00007f721631bfe4 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f721631c0ec in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f721c5137be in QEventDispatcherGlib::processEvents (this=0x7f72000008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:436
#4  0x00007f721c4e50af in QEventLoop::processEvents (this=this@entry=0x7f720564ada0, flags=...) at kernel/qeventloop.cpp:149
#5  0x00007f721c4e53a5 in QEventLoop::exec (this=this@entry=0x7f720564ada0, flags=...) at kernel/qeventloop.cpp:204
#6  0x00007f721c3e1c5f in QThread::exec (this=this@entry=0x1f69e80) at thread/qthread.cpp:537
#7  0x00007f721c4c6823 in QInotifyFileSystemWatcherEngine::run (this=0x1f69e80) at io/qfilesystemwatcher_inotify.cpp:265
#8  0x00007f721c3e432f in QThreadPrivate::start (arg=0x1f69e80) at thread/qthread_unix.cpp:349
#9  0x00007f7216c3f182 in start_thread (arg=0x7f720564b700) at pthread_create.c:312
#10 0x00007f721b818fbd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Thread 1 (Thread 0x7f72223f6800 (LWP 18067)):
[KCrash Handler]
#6  0x0000000000530772 in _start ()

Reproducible: Always

Steps to Reproduce:
1. Create a new entry with the title 'Pixi' and save it.
2. Right click the new entry -> select Update Entry -> select ISBNdb.com (or all sources)

Actual Results:  
Tellico crashes

Expected Results:  
Tellico does not crash and tries to update the entry.
Comment 1 Robby Stephenson 2014-10-11 23:55:00 UTC
Git commit cbf8892b172734c70c973393f9094f865dc12aac by Robby Stephenson.
Committed on 11/10/2014 at 23:50.
Pushed by rstephenson into branch '2.3'.

Check for collection pointer before dereferencing ISBN results

Fix a crashing bug for some ISBNdb.org results by verifying a valid
collection pointer. The libxml reader was returning a null object after
trying to read invalid XML returned by ISBNdb.org.
FIXED-IN: 2.3.10

M  +1    -0    ChangeLog
M  +10   -1    src/fetch/isbndbfetcher.cpp