Bug 339044 - CSV import wizard does not appear to be working.
Summary: CSV import wizard does not appear to be working.
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: importer (show other bugs)
Version: 4.6.6
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-13 09:37 UTC by kroyall
Modified: 2014-09-20 22:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screen Shot of CSV Import Wizard (73.21 KB, image/jpeg)
2014-09-13 11:28 UTC, kroyall
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kroyall 2014-09-13 09:37:43 UTC
When I try to import a csv file into a mymoney file, the wizard opens but then freezes.  It won't let me select either the banking or investment radio button.

Reproducible: Always

Steps to Reproduce:
1. select file/import/CSV
2.
3.

Actual Results:  
The CSV import wizard opens up then freeezes, and neither the 'banking' nor 'Investment' radio buttons can be selected.

Expected Results:  
The import wizard opensed. I expected to be able to choose either the 'banking' or 'investment' radio button causing the wizard to move to the 'Add new profile' window.

I have installed MyMoney on a computer with the windows 8.1
Comment 1 allan 2014-09-13 10:11:02 UTC
This is very strange.  There are two different versions of the CSV importer plugin.  The older one is not in wizard format, but has three tabbed pages, for Banking, Investment and Settings.  That is the version I see on my KMyMoney v 4.6.6 (on LInux).  As you say you have installed 4.6.6, on Windows, that would be the version I would expect you to see.

How did you install the KMyMoney you have?  Also, in KMyMoney, would you click on Help->About KMyMoney, and say what version is shown there.  A screen-shot of the whole CSV importer window might be useful too, if you could attach it to the bug report.

That aside, both versions do work, and the wizard version is more up-to-date.  So, I need to make enquiries about the Windows build.
Comment 2 kroyall 2014-09-13 11:28:15 UTC
Created attachment 88692 [details]
Screen Shot of CSV Import Wizard
Comment 3 kroyall 2014-09-13 12:12:53 UTC
I downloaded the installation file from the KDE Web site, and installed as normal
Comment 4 allan 2014-09-13 12:15:48 UTC
(In reply to kroyall from comment #3)
> I downloaded the installation file from the KDE Web site, and installed as
> normal

OK.  Thanks for the screenshot.  It wasn't quite complete, I'm afraid, but if you could say if, at the foot of the window, the three buttons are displayed correctly.
Also, just to be sure, "in KMyMoney, would you click on Help->About KMyMoney, and say what version is shown there."
I suspect that you do not actually have the 4.6.6 version, but one from the development branch.  This, I'm afraid, has a problem on Windows.  A fixed version should be available within a few weeks or so.
Comment 5 kroyall 2014-09-13 12:16:51 UTC
Sorry Allan 

The version I have is 4.6.90, which isn't listed in the drop down box for versions, so I chose 4.6.6 as a generic version.

I downloaded the installation file directly from the KDE web site.


I've attached a screen shot to the bug report

Regards

Keith Royall

-----Original Message-----
From: bugzilla_noreply@kde.org [mailto:bugzilla_noreply@kde.org] On Behalf Of allan
Sent: 13 September 2014 11:11
To: keithroyall@visitnz.plus.com
Subject: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working.

https://bugs.kde.org/show_bug.cgi?id=339044

allan <agander93@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agander93@gmail.com

--- Comment #1 from allan <agander93@gmail.com> --- This is very strange.  There are two different versions of the CSV importer plugin.  The older one is not in wizard format, but has three tabbed pages, for Banking, Investment and Settings.  That is the version I see on my KMyMoney v
4.6.6 (on LInux).  As you say you have installed 4.6.6, on Windows, that would be the version I would expect you to see.

How did you install the KMyMoney you have?  Also, in KMyMoney, would you click on Help->About KMyMoney, and say what version is shown there.  A screen-shot of the whole CSV importer window might be useful too, if you could attach it to the bug report.

That aside, both versions do work, and the wizard version is more up-to-date. 
So, I need to make enquiries about the Windows build.

--
You are receiving this mail because:
You reported the bug.
Comment 6 allan 2014-09-13 13:19:37 UTC
(In reply to kroyall from comment #5)
> Sorry Allan 
> 
> The version I have is 4.6.90, which isn't listed in the drop down box for
> versions, so I chose 4.6.6 as a generic version.
> 
> I downloaded the installation file directly from the KDE web site.
> I've attached a screen shot to the bug report
> 
> Regards
> 
> Keith Royall
OK.  As I said,  that version has a problem under Windows.  Pending that fix, you could try the previous version,  4.6.4, from http://sourceforge.net/projects/kmymoney2/files/KMyMoney-Windows/ .  That is the tabbed version.
Comment 7 kroyall 2014-09-13 20:25:55 UTC
Hi Allan

When you say 'Buttons' do you mean radio buttons or just ordinary buttons?

If you mean Radio buttons, there are only 2 labelled 'Banking' and 'Investment' respectively.

If you mean there should be 3 ordinary buttons as well, there isn't.

Keith


-----Original Message-----
From: bugzilla_noreply@kde.org [mailto:bugzilla_noreply@kde.org] On Behalf Of allan
Sent: 13 September 2014 13:16
To: keithroyall@visitnz.plus.com
Subject: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working.

https://bugs.kde.org/show_bug.cgi?id=339044

--- Comment #4 from allan <agander93@gmail.com> --- (In reply to kroyall from comment #3)
> I downloaded the installation file from the KDE Web site, and 
> installed as normal

OK.  Thanks for the screenshot.  It wasn't quite complete, I'm afraid, but if you could say if, at the foot of the window, the three buttons are displayed correctly.
Also, just to be sure, "in KMyMoney, would you click on Help->About KMyMoney, and say what version is shown there."
I suspect that you do not actually have the 4.6.6 version, but one from the development branch.  This, I'm afraid, has a problem on Windows.  A fixed version should be available within a few weeks or so.

--
You are receiving this mail because:
You reported the bug.
Comment 8 allan 2014-09-13 22:38:12 UTC
(In reply to kroyall from comment #7)
> Hi Allan
> 
> When you say 'Buttons' do you mean radio buttons or just ordinary buttons?
> 
> If you mean Radio buttons, there are only 2 labelled 'Banking' and
> 'Investment' respectively.
> 
> If you mean there should be 3 ordinary buttons as well, there isn't.
> 
> Keith

There should be three ordinary buttons at the foot of the wizard page, for Back, Select File and Cancel.  That they're missing (or rather, out of view), as I suspected, is part of the issue under Windows.

Allan
Comment 9 Jack 2014-09-16 02:46:28 UTC
I can confirm that with the development version on Windows Vista, the CSV importer shows the radio buttons, but not the three regular buttons which should be below them.  It's not clear to me whether the radio buttons can be selected or not.  When I click on one, the circle outline gets highlighted, but does not appear filled in.  I don't know if this is a problem, related or not, or just a side effect of the theme on Windows.  However, this does match Cristian's statement (I've forgotten where, but I thought it was in email to the developers' mailing list) that this is known broken in this version.
Comment 10 allan 2014-09-16 05:48:49 UTC
Thanks, Jack.  I've fixed that problem here, in my sandbox.  I'm working at the moment on a revised version.  
Allan

Jack <ostroffjh@users.sourceforge.net> wrote:

>https://bugs.kde.org/show_bug.cgi?id=339044
>
>--- Comment #9 from Jack <ostroffjh@users.sourceforge.net> ---
>I can confirm that with the development version on Windows Vista, the CSV
>importer shows the radio buttons, but not the three regular buttons which
>should be below them.  It's not clear to me whether the radio buttons can be
>selected or not.  When I click on one, the circle outline gets highlighted, but
>does not appear filled in.  I don't know if this is a problem, related or not,
>or just a side effect of the theme on Windows.  However, this does match
>Cristian's statement (I've forgotten where, but I thought it was in email to
>the developers' mailing list) that this is known broken in this version.
>
>-- 
>You are receiving this mail because:
>You are on the CC list for the bug.
Comment 11 allan 2014-09-16 11:28:08 UTC
To Jack
I still have  a bit more work to do before pushing/whatever, but the revised plugin now shows the buttons correctly and is responsive, on my Ubuntu system, which previously did not display the buttons correctly.
I'm concerned though about what you say about the radio buttons not working, which I've never encountered.  So, I've produced a temporary version with the UI files replaced, but which is otherwise derived from git HEAD.  There is a problem on this with scrolling, which works correctly on the full version i'm finishing, so I'm not concerned about that.
Might you have time please to install this patch, to see if the new UI files allow the plugin to work on Windows and allows the wizard pages to be navigated.
Comment 12 allan 2014-09-19 12:56:01 UTC
Git commit 1d84d3ba8f71da3259eb6a9eec53c6f8393fac1a by Allan Anderson.
Committed on 19/09/2014 at 12:48.
Pushed by allananderson into branch 'master'.
REVIEW:120260 -
Fix CSV import wizard not working correctly on Windows

M  +171  -337  kmymoney/plugins/csvimport/bankingwizardpage.ui
M  +120  -175  kmymoney/plugins/csvimport/completionwizardpage.ui
M  +48   -73   kmymoney/plugins/csvimport/csvdialog.cpp
M  +3    -2    kmymoney/plugins/csvimport/csvdialog.h
M  +294  -244  kmymoney/plugins/csvimport/csvdialog.ui
M  +5    -1    kmymoney/plugins/csvimport/csvutil.cpp
M  +1    -0    kmymoney/plugins/csvimport/csvutil.h
M  +111  -213  kmymoney/plugins/csvimport/introwizardpage.ui
M  +271  -353  kmymoney/plugins/csvimport/investmentwizardpage.ui
M  +7    -64   kmymoney/plugins/csvimport/investprocessing.cpp
M  +0    -1    kmymoney/plugins/csvimport/investprocessing.h
M  +179  -257  kmymoney/plugins/csvimport/lines-datewizardpage.ui
M  +128  -233  kmymoney/plugins/csvimport/separatorwizardpage.ui

http://commits.kde.org/kmymoney/1d84d3ba8f71da3259eb6a9eec53c6f8393fac1a
Comment 13 Cristian Oneț 2014-09-20 22:50:08 UTC
Git commit 184fb8bbed381de4a847ccf5d41cfb48c7ecd8d1 by Cristian Oneț, on behalf of Allan Anderson.
Committed on 19/09/2014 at 12:48.
Pushed by conet into branch 'frameworks'.
REVIEW:120260 -
Fix CSV import wizard not working correctly on Windows

(cherry picked from commit 1d84d3ba8f71da3259eb6a9eec53c6f8393fac1a)

Conflicts:
	kmymoney/plugins/csvimport/investmentwizardpage.ui

M  +171  -337  kmymoney/plugins/csvimport/bankingwizardpage.ui
M  +120  -175  kmymoney/plugins/csvimport/completionwizardpage.ui
M  +48   -73   kmymoney/plugins/csvimport/csvdialog.cpp
M  +3    -2    kmymoney/plugins/csvimport/csvdialog.h
M  +294  -244  kmymoney/plugins/csvimport/csvdialog.ui
M  +5    -1    kmymoney/plugins/csvimport/csvutil.cpp
M  +1    -0    kmymoney/plugins/csvimport/csvutil.h
M  +111  -213  kmymoney/plugins/csvimport/introwizardpage.ui
M  +271  -353  kmymoney/plugins/csvimport/investmentwizardpage.ui
M  +7    -64   kmymoney/plugins/csvimport/investprocessing.cpp
M  +0    -1    kmymoney/plugins/csvimport/investprocessing.h
M  +179  -257  kmymoney/plugins/csvimport/lines-datewizardpage.ui
M  +128  -233  kmymoney/plugins/csvimport/separatorwizardpage.ui

http://commits.kde.org/kmymoney/184fb8bbed381de4a847ccf5d41cfb48c7ecd8d1