Bug 33902 - [test case] www.epinions.com not rendered (tokenizer problem with bad HTML)
Summary: [test case] www.epinions.com not rendered (tokenizer problem with bad HTML)
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml parsing (show other bugs)
Version: 4.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 40233 44413 71652 72455 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-19 11:48 UTC by András Manţia
Modified: 2010-01-11 04:14 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
tescase (659 bytes, text/html)
2002-10-04 23:11 UTC, Georg Robbers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2001-10-19 11:34:37 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           kjs
Version:           unknown (using KDE 2.2.1 )
Severity:          normal
Installed from:    compiled sources
Compiler:          gcc version 2.95.3 20010315 (release)
OS:                SunOS (sun4u) release 5.6
OS/Compiler notes: 

If I go to the www.epinions.com only the title bar is visible altoguh by looking to the document source evertyhing is downloaded (but not rendered to the screen). By disabling javascript the page is rendered correctly.

Andras

PS: the "page not rendered" error happens also for some bug-reports (mainly the generated messages telling about closing a bug-report). I don't know if disabling javascript helps in that case or not bu next time when I experience the error I will check.

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Stephan Binner 2002-02-02 22:15:38 UTC
Only "Auto" tab is not rendered by KDE 2.2.2 and 3.0 Beta2.
Comment 2 John Firebaugh 2002-09-30 01:45:03 UTC
*** Bug 44413 has been marked as a duplicate of this bug. ***
Comment 3 John Firebaugh 2002-09-30 01:45:08 UTC
*** Bug 40233 has been marked as a duplicate of this bug. ***
Comment 4 Georg Robbers 2002-10-04 23:11:28 UTC
Created attachment 140 [details]
tescase

Some of the epinions pages had <noscript> tags for the javascript generatet
doubleclick-ads - with quotes(!). That might explain the javascript on/off
difference.
Comment 5 David Faure 2002-11-10 21:06:51 UTC
Ok so it's not a javascript bug. 
Can anyone test the testcase in IE? Mozilla can't really be used as reference, it has many bugs. 
Comment 6 András Manţia 2002-11-11 13:37:05 UTC
Subject: Re:  www.epinions.com not rendered (tokenizer problem with bad HTML)

Do you mean see how IE renders the www.epinions.com? I can test anything you 
want with IE.

Andras

PS: I reported this bug some time in the past on Solaris, but a week ago I 
noticed the same thing on Linux and KDE HEAD. Netscape 6 didn't had any 
problem.

On 2002. November 10., Sunday 22:06, you wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=33902
> faure@kde.org changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Component|kjs                         |khtml
>             Summary|www.epinions.com not        |www.epinions.com not
>
>                    |rendered with javascript    |rendered (tokenizer
>                    | problem enabled                     |with bad HTML)
>
> ------- Additional Comments From faure@kde.org  2002-11-10 21:06 -------
> Ok so it's not a javascript bug.
> Can anyone test the testcase in IE? Mozilla can't really be used as
> reference, it has many bugs.

Comment 7 Georg Robbers 2002-11-11 21:29:39 UTC
IE 6 does render the "Mozilla does." part of the testcase, just like Mozilla. It's  
just Konqi that doesn't.  
Comment 8 Daniel Naber 2003-06-07 16:39:18 UTC
Works okay in CVS. 
Comment 9 Fauzie Wiriadisastra 2003-10-07 05:41:09 UTC
Hi, the problem appears again in 3.1.4 
Disabling JS fixed it. Something is still wrong with with konq. 
Comment 10 George Staikos 2003-10-07 05:54:02 UTC
It doesn't happen in HEAD, and I see no JS errors either.  We actually render 
the site far nicer than mozilla does. 
Comment 11 Maksim Orlovich 2004-01-12 17:38:46 UTC
Back again, not on the front page though, testcase still fails
Comment 12 Maksim Orlovich 2004-01-12 17:39:03 UTC
*** Bug 71652 has been marked as a duplicate of this bug. ***
Comment 13 Maksim Orlovich 2004-01-12 17:39:15 UTC
*** Bug 72455 has been marked as a duplicate of this bug. ***
Comment 14 Jim Simon 2004-05-22 16:49:59 UTC
Pages render properly with Javascript turned on using KDE 3.2.2.
Comment 15 Michael Jahn 2004-07-20 00:22:45 UTC
The "Mozilla does"-portion of the testcase in comment #4 is not shown with HEAD.
Comment 16 Ian Ventura-Whiting 2006-08-29 14:57:47 UTC
Issue does not exist in the latest version of KDE / Konqueror (3.5.4 from source). Please close.
Comment 17 Tommi Tervo 2006-08-29 15:36:40 UTC
testcase #4 still fails (snv r457k)
Comment 18 András Manţia 2007-07-24 08:54:26 UTC
Changing OS to Linux, as it fails on that as well as of today.
Comment 19 Stefan Monov 2007-09-12 11:25:09 UTC
testcase #4 still fails in trunk
Comment 20 George Goldberg 2008-04-03 13:38:21 UTC
testcase in comment #4 still fails on svn trunk r790203
Comment 21 FiNeX 2008-06-27 17:38:59 UTC
Confirmed in current trunk too... anyway, I'm still asking to myself, why a web developer should do something like that. -_-
Comment 22 András Manţia 2009-02-15 12:10:02 UTC
Testcase fails in trunk.
Comment 23 Jaime Torres 2010-01-08 16:25:38 UTC
SVN commit 1071706 by jtamate:

BUG: 33902
follow html5 unquoted attribute sintax
http://reviewboard.kde.org/r/1849/

 M  +4 -1      htmltokenizer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071706
Comment 24 Tommi Tervo 2010-01-10 22:18:13 UTC
This fix caused a regression: Images.google.com doesn't load image previews, e.g.: http://images.google.com/images?q=nasobem
Comment 25 Germain Garand 2010-01-11 04:14:26 UTC
Ouch, I see Maksim fixed it already, but I'm no longer much supportive of this patch...

I thought I had tested the behaviour in Mozilla, but my test was bogus : it used the content css property, which isn't supported inside style attribute by Gecko, so the characters weren't actually stoping the attribute parsing as I thought :-(

Retesting, I see even fairly modern Gecko doesn't in fact end the attribute for any of single quote, double quote, less-than or grave accent.

Other UAs also allow single quote, double quote, less-than or grave accent.

The potential for other breakage is really high, so it's probably wiser to just revert the rest of it.

@Jaime: sorry about that, the only way to fix this bug then will be to fix parsing of attribute name <div ' > that's the real matter