Bug 338500 - ValidateSendMailShortcut::validate use of KMessageBox::questionYesNoCancel is not good user experience wise
Summary: ValidateSendMailShortcut::validate use of KMessageBox::questionYesNoCancel is...
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: general (show other bugs)
Version: 4.14.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-08-23 11:55 UTC by Albert Astals Cid
Modified: 2014-10-23 05:53 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kdepim/a8e69f809d0add3b8a7048ddac03771706d9b6c8
Version Fixed In: 4.14.3

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2014-08-23 11:55:33 UTC 
I just upgraded to 4.14.0, now on the first Ctrl+Enter to send i got this dialog asking me what i wanted to do, i understand this is good because previously sending emails without warning was a bit scary for some people.

The problem is that the dialog is a KMessageBox::questionYesNoCancel so if i press the "Esc" key what gets triggered is the "Cancel", so the dialog thinks the person clicked on "Sending Without Confirmation"

Probably we should use something different than a KMessageBox::questionYesNoCancel so that "Esc" either does nothing or something more "safe" for what "Esc" usually means.
Comment 1 Laurent Montel 2014-10-23 05:53:36 UTC 
Git commit a8e69f809d0add3b8a7048ddac03771706d9b6c8 by Montel Laurent.
Committed on 23/10/2014 at 05:52.
Pushed by mlaurent into branch 'KDE/4.14'.

Fix Bug 338500 - ValidateSendMailShortcut::validate use of KMessageBox::questionYesNoCancel is not good user experience wise

FIXED-IN: 4.14.3

M  +15   -14   kmail/editor/validatesendmailshortcut.cpp

http://commits.kde.org/kdepim/a8e69f809d0add3b8a7048ddac03771706d9b6c8