Bug 338280 - FindFFmpeg.cmake bug
Summary: FindFFmpeg.cmake bug
Status: RESOLVED FIXED
Alias: None
Product: kdemultimedia
Classification: Miscellaneous
Component: ffmpegthumbs (show other bugs)
Version: 4.11.5
Platform: NetBSD pkgsrc All
: NOR normal
Target Milestone: ---
Assignee: Multimedia Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 19:25 UTC by Thomas Klausner
Modified: 2014-08-15 21:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.1


Attachments
Patch addressing the issue. (519 bytes, text/x-cmake)
2014-08-14 19:25 UTC, Thomas Klausner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Klausner 2014-08-14 19:25:46 UTC
Created attachment 88258 [details]
Patch addressing the issue.

ffmpegthumbs distributes the same file for detecting ffmpeg as kdelibs4 and thus is affected by bug #338266 (https://bugs.kde.org/show_bug.cgi?id=338266). The same patch applies, but I'm not sure who the master source is for this file.

In short: The pkg-config detection output is saved in a variable, but a different variable is used in the code below, breaking ffmpeg detection in non-standard locations.
Comment 1 Albert Astals Cid 2014-08-15 21:05:15 UTC
Git commit afcc7af91967fb66145bef0c74f811b3c58da80c by Albert Astals Cid.
Committed on 15/08/2014 at 21:04.
Pushed by aacid into branch 'KDE/4.14'.

FindFFmpeg: Use the right name for the pkg-config component variables.

Commit 3194a35e ("Rewritten FindFFmpeg.cmake") introduced a regression
in the find_component macro: the pkg_check_module() call uses
PC_${component} as the variable name, while the calls to find_path() and
find_library() use PC_LIB${component} instead.

Fix the calls to find_path() and find_library().

Based on a patch by Thomas Klausner <tk@giga.or.at>, thanks a lot!

Copied from kdelibs commit f6d33b3a2d1077c91425819de145ba2e5ae3cd87
FIXED-IN: 4.14.1

M  +5    -5    cmake/FindFFmpeg.cmake

http://commits.kde.org/ffmpegthumbs/afcc7af91967fb66145bef0c74f811b3c58da80c