Bug 338276 - CANVAS : mouse-over preview mode does not work [patch]
Summary: CANVAS : mouse-over preview mode does not work [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Canvas (show other bugs)
Version: 4.2.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 18:03 UTC by Samuel Gilbert
Modified: 2016-07-02 09:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.0
Sentry Crash Report:


Attachments
colorpicker.patch (613 bytes, patch)
2014-12-11 19:50 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Gilbert 2014-08-14 18:03:33 UTC
In the image editor, when performing a modification with a preview, the mouse-over preview works only once.  When changed to "After" it doesn't go back to before even when the mouse cursor is placed on top of the image.

Reproducible: Always

Steps to Reproduce:
1. Select an image in an album
2. Press F4 to open the image editor
3. In the menu, select an operation such as Color -> White Balance
4. Use the color picker and click somewhere in the image
5. Move the mouse cursor over the panel on the right side to display the "After"
6. Move the mouse cursor back over the image
Actual Results:  
The image stays at "After".

Expected Results:  
The image displayed image should be "Before" when the mouse cursor is brought back over the image.

Clicking in the image will make it change back to "Before"
Comment 1 caulier.gilles 2014-08-14 18:08:13 UTC
You need to move over image content, not canvas.

If you zoom over and image do not fill all canvas, region where no image data is displayed are not sensible to mouse over.

I'm sure, i use this mode all days, and all work as explained before perfectly.

I agree : this behavior is a regression compared to 3.x release and must be fixed.

Gilles Caulier
Comment 2 Samuel Gilbert 2014-08-14 18:15:22 UTC
The image was zoomed to "Fit to Window" and took almost all the space available in the canvas.  I brought the mouse cursor back over the actual image and it did not change.
Comment 3 Jan Wolter 2014-12-10 18:53:46 UTC
I justed this issue on 4.6.0 and I can confirm the problem exactly in the way Samuel explained it.

I tested a bit and the problem occures just after clicking with the color picker. After that, moving the mouse over the picture does not show the "before" state as expected. But clicking somewhere in the picture brings the "before" state as long you leave the cursor on the picture canvas.
Comment 4 Jan Wolter 2014-12-10 19:09:55 UTC
The same problem occures also in the three other tools that use a color picker: levels adjust, curves adjust, and color negative.
Comment 5 Maik Qualmann 2014-12-11 19:50:30 UTC
Created attachment 89923 [details]
colorpicker.patch

This patch fixes problems with the color picker. The mouse tracking is disabled after selection. Another problem was when one has often pushed the color picker button, the original preview mode was activated.
Comment 6 caulier.gilles 2014-12-11 22:03:20 UTC
Git commit 06483c675c53e09d19e0f31f30777fdb7d1d38ae by Gilles Caulier.
Committed on 11/12/2014 at 22:01.
Pushed by cgilles into branch 'master'.

Apply patch #89923 from Maik Qualmann about to fix mouse over editor tool preview mode when color picker is used.
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +6    -1    utilities/imageeditor/widgets/imageregionwidget.cpp

http://commits.kde.org/digikam/06483c675c53e09d19e0f31f30777fdb7d1d38ae