Bug 338200 - Cancelling tags assigment in file metadata does not work [patch]
Summary: Cancelling tags assigment in file metadata does not work [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ProgressManager-Usability (show other bugs)
Version: 4.2.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 17:01 UTC by DrSlony
Modified: 2022-02-05 15:59 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.12.0
Sentry Crash Report:


Attachments
cancelworker.patch (6.46 KB, patch)
2015-07-21 10:39 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2014-08-11 17:01:14 UTC
I assigned a tag to about a thousand raw photos, with the "write metadata to raw files" option enabled. As it was taking very long, I wanted to cancel this and to run it at night. Clicking the "Cancel this operation" button at 31% did nothing.
Comment 1 caulier.gilles 2015-05-15 22:06:26 UTC
Maik, 

In this file, the loop to process image with tags assignment is performed by FileActionMngr. See ImageDescEditTab::slotApplyAllChanges().

I check code in FileActionMngr and it's connected to Progress Manager.

Can you reproduce the dysfunction ?

Gilles
Comment 2 Maik Qualmann 2015-07-21 10:39:20 UTC
Created attachment 93679 [details]
cancelworker.patch

With this patch, the write metadata to DB and files can be canceled.

Maik
Comment 3 caulier.gilles 2015-07-21 12:13:03 UTC
Patch sound fine for me...
But we must know the current talk between Veaceslav and Marcel about KF5 port dysfunctions from FileActionMngr. I CC you for info by private mail.

Gilles
Comment 4 caulier.gilles 2015-07-21 12:15:27 UTC
MAik,

I forwarded the thread between Veaceslav and Marcel.

Did you manage to backport this patch to Frameworks branch ?

Gilles
Comment 5 Maik Qualmann 2015-07-21 20:51:20 UTC
Git commit 14f77f54d47de008a249360942449a4d04f60aa1 by Maik Qualmann.
Committed on 21/07/2015 at 20:44.
Pushed by mqualmann into branch 'master'.

apply patch #93679 to writing the metadata to the DB and the files can be canceled
FIXED-IN: 4.12.0

M  +2    -1    NEWS
M  +39   -0    app/fileaction/databaseworkeriface.cpp
M  +11   -2    app/fileaction/fileactionmngr_p.cpp
M  +1    -0    app/fileaction/fileactionmngr_p.h
M  +19   -0    app/fileaction/fileworkeriface.cpp

http://commits.kde.org/digikam/14f77f54d47de008a249360942449a4d04f60aa1
Comment 6 Maik Qualmann 2015-07-29 17:20:30 UTC
Git commit 5493e5b912c4b2c9df0fc1cb05539fd542e5129d by Maik Qualmann.
Committed on 29/07/2015 at 17:11.
Pushed by mqualmann into branch 'frameworks'.

backport commit #14f77f54d47de008a249360942449a4d04f60aa1 from git/master to frameworks branch

M  +39   -0    libs/fileactionmanager/databaseworkeriface.cpp
M  +11   -2    libs/fileactionmanager/fileactionmngr_p.cpp
M  +1    -0    libs/fileactionmanager/fileactionmngr_p.h
M  +19   -0    libs/fileactionmanager/fileworkeriface.cpp

http://commits.kde.org/digikam/5493e5b912c4b2c9df0fc1cb05539fd542e5129d