Bug 338183 - Plasma scales the user sets icon sizes
Summary: Plasma scales the user sets icon sizes
Status: RESOLVED DUPLICATE of bug 338308
Alias: None
Product: plasmashell
Classification: Plasma
Component: Widget Explorer sidebar (show other bugs)
Version: master
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 07:49 UTC by enoopt.adams
Modified: 2014-08-25 10:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Picture of problem (1.72 MB, image/png)
2014-08-11 07:49 UTC, enoopt.adams
Details

Note You need to log in before you can comment on or make changes to this bug.
Description enoopt.adams 2014-08-11 07:49:00 UTC
Created attachment 88214 [details]
Picture of problem

The widget icons are oversized, taking up so much room that the title of widgets gets truncated.
Comment 1 David Edmundson 2014-08-21 16:41:14 UTC
I use 
width: units.iconSizes.huge


which comes from.    

m_iconSizes->insert("huge", devicePixelIconSize(KIconLoader::SizeHuge));

which in turn is scaling
QGuiApplication::primaryScreen()->physicalDotsPerInchX()
--

enoopt, can you include output from "xrandr -q"


--
I don't know why we don't just use the user's set icon size that they set in the icons KCM. Seems like it'd be better than randomly scaling things ourselves.
Comment 2 David Edmundson 2014-08-21 16:51:55 UTC

*** This bug has been marked as a duplicate of bug 338308 ***
Comment 3 Sebastian Kügler 2014-08-25 09:35:30 UTC
We are not "randomly scaling" the icons ourselves, we're relying on DPI information to scale the icon size according to the DPI value. I guess you know that, so not sure where the random comes from.

Using the settings from the user can still be done, and will take effect, but the DPI scaling will be intact, so it's not breaking that feature. Ignoring DPI will mean that we lose all the HiDPI goodness we introduced with exactly this scaling algorithm -- a huge step back for many users.
Comment 4 David Edmundson 2014-08-25 10:33:58 UTC
Random == DPI calculations from X can't be trusted and in some cases (many it seems) are completely random.

It's why we use the user's font size everywhere else, except for icons.