Bug 337878 - THUMBBAR : item focus must stay in the middle [patch]
Summary: THUMBBAR : item focus must stay in the middle [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-BarView (show other bugs)
Version: 4.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 10:25 UTC by Greg4b
Modified: 2017-07-28 15:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.0
Sentry Crash Report:


Attachments
focus should stay in the middle (555.36 KB, image/png)
2014-07-29 10:26 UTC, Greg4b
Details
scrolltocenter.patch (1.01 KB, patch)
2015-03-30 19:32 UTC, Maik Qualmann
Details
scrolltocenter2.patch (7.48 KB, patch)
2015-04-02 18:44 UTC, Maik Qualmann
Details
scrolltocenter3.patch (4.69 KB, patch)
2015-05-20 21:06 UTC, Maik Qualmann
Details
scrolltocenter4.patch (4.77 KB, patch)
2015-05-21 20:02 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Greg4b 2014-07-29 10:25:29 UTC
Current behavior: the focus is in the right side of the area - thus not showing the upcoming pictures.

Whishing behavior: focus stays in the middle fixed and at least the next 2 and the last 2 pictures are shown (or more)

        FOCUS
-2   -1   0   +1   +2
Comment 1 Greg4b 2014-07-29 10:26:13 UTC
Created attachment 88010 [details]
focus should stay in the middle
Comment 2 caulier.gilles 2015-03-26 06:58:52 UTC
digiKam 4.7.0 for Windows is available :

http://download.kde.org/stable/digikam/digiKam-installer-4.7.0-1-win32.exe.mirrorlist

Please test and report.

Thanks in advance

Gilles Caulier
Comment 3 Maik Qualmann 2015-03-30 19:32:51 UTC
Created attachment 91823 [details]
scrolltocenter.patch

I need a feedback, whether you like this feature. This patch centered the current image in the preview mode of the import and digikam thumb bar.

Maik
Comment 4 caulier.gilles 2015-03-30 21:31:24 UTC
Maik,

Your patch touch stackedview from Album GUI and Import tool to control position of thumbbar items when contents is review in preview mode. 

What's about Image editor and showfoto. I can load dir with more than one items and change item focus with pageup page down while thumbbar is displayed near canvas. It can make a sense also to have current item loaded in thumbbar center.

Other case is LightTable where a thumbar is used to view items list on pool. We can change item to compare on the right side with item on the left side using keyboard. In this case thumbbar focus must follow item displayed on right canvas...

Gilles
Comment 5 Greg4b 2015-03-31 06:33:51 UTC
(In reply to Maik Qualmann from comment #3)
> Created attachment 91823 [details]
> scrolltocenter.patch
> 
> I need a feedback, whether you like this feature. This patch centered the
> current image in the preview mode of the import and digikam thumb bar.
> 
> Maik

Hello Maik,

I'm sorry, but I'm not familiar with patches...

I've tried Version 4.7.0 Using KDE Development Platform 4.10.2 and the situation is unchaned.

I could provide feedback, when Instruction about patching the Version 4.7.0 is provided.

Thanks,

Gregor
Comment 6 caulier.gilles 2015-03-31 07:14:27 UTC
Greg,

The patch is not intrusive and can be applied to 4.7.0 source code.

This want to have digiKam source code on your computer and to apply patch to source. Recompilation and re-installation is of course mandatory.

Did you install digiKam through a package or using source code (tarball) ?

Gilles Caulier
Comment 7 Greg4b 2015-03-31 08:24:38 UTC
Hello Gilles,

I've installed the Version 4.7.0 through a package.

I'm afraid, I'm not able to install a development environment, since this is a company computer.

Thanks,

Gregor
Comment 8 Maik Qualmann 2015-04-02 18:44:33 UTC
Created attachment 91865 [details]
scrolltocenter2.patch

This patch for testing contains now all thumb bars. It is a time controlled scroll activation needed to obtain a uniform visual feedback.
For to LightTable I find the centering of the thumbnails more of a hindrance. ShowFoto has the thumb bar a KineticScroller - was unknown to me, nice. Here test the interaction. Could the centering of the thumbnails disrupt the workflow of other users?

Maik
Comment 9 caulier.gilles 2015-05-08 10:05:55 UTC
The patch has some problems with D&D.

From thumb-bars it's possible to operate D&D with other parts of application (or with extra applications as Dolphin for ex)

Your current patch scroll thumb-bar to the center when D&D start to be initiate. This is very problematic...

Typically, you must :

1/ detect is D&D is initiate.
2/ scroll selected item to center after that D&D is completed, else GUI behavior is confuse.

Gilles
Comment 10 Maik Qualmann 2015-05-08 10:31:52 UTC
Yes, D&D is broken. I also find that if you use the buttons, the thumbnail image should not jump, but firmly stand in the middle.

Maik
Comment 11 caulier.gilles 2015-05-16 13:35:34 UTC
Maik, 

Any progress here ?

Did you seen also bug #338918 ? It can depend of this file i think...

Gilles
Comment 12 caulier.gilles 2015-05-16 21:54:24 UTC
Maik,

There is another entry in bugzilla which depend of this one more or less :

https://bugs.kde.org/show_bug.cgi?id=344952

Gilles
Comment 13 Maik Qualmann 2015-05-20 21:06:25 UTC
Created attachment 92743 [details]
scrolltocenter3.patch

New patch for testing to center the current thumbnail.

Maik
Comment 14 caulier.gilles 2015-05-21 08:56:47 UTC
Maik

Patch version 3 work perfectly. Great job...

Note : bug #338918 can be closed also with this file...

Gilles
Comment 15 Maik Qualmann 2015-05-21 20:02:03 UTC
Created attachment 92772 [details]
scrolltocenter4.patch

Final version of the patch to commit.

Maik
Comment 16 Maik Qualmann 2015-05-21 20:03:11 UTC
Git commit e2b0732413b4ffbd0d0ca59e60a6dd165c33ea38 by Maik Qualmann.
Committed on 21/05/2015 at 19:54.
Pushed by mqualmann into branch 'master'.

apply patch #92772 to scroll the current index to center of the view
Related: bug 344952
FIXED-IN: 4.11.0

M  +3    -1    NEWS
M  +1    -0    app/items/imagethumbnailbar.cpp
M  +33   -0    libs/widgets/itemview/dcategorizedview.cpp
M  +4    -0    libs/widgets/itemview/dcategorizedview.h
M  +1    -0    showfoto/thumbbar/showfotothumbnailbar.cpp
M  +1    -0    utilities/importui/views/importthumbnailbar.cpp

http://commits.kde.org/digikam/e2b0732413b4ffbd0d0ca59e60a6dd165c33ea38
Comment 17 caulier.gilles 2015-05-22 14:28:19 UTC
Git commit b1202b4ec7042bb115fba39d2f20d1238fd42b5a by Gilles Caulier.
Committed on 22/05/2015 at 14:27.
Pushed by cgilles into branch 'frameworks'.

backport commit #e2b0732413b4ffbd0d0ca59e60a6dd165c33ea38 from git/master to frameworks branch
Related: bug 344952

M  +1    -0    app/items/imagethumbnailbar.cpp
M  +33   -0    libs/widgets/itemview/itemviewcategorized.cpp
M  +4    -0    libs/widgets/itemview/itemviewcategorized.h
M  +1    -0    showfoto/thumbbar/showfotothumbnailbar.cpp
M  +1    -0    utilities/importui/views/importthumbnailbar.cpp

http://commits.kde.org/digikam/b1202b4ec7042bb115fba39d2f20d1238fd42b5a
Comment 18 Maik Qualmann 2015-06-30 17:58:54 UTC
Git commit 820c66bac12f1f0b00b4b1ba1deef5dc64d30397 by Maik Qualmann.
Committed on 30/06/2015 at 17:56.
Pushed by mqualmann into branch 'master'.

fixing scroll to center of the thumb bar when an image is deleted
Related: bug 344952

M  +10   -0    libs/widgets/itemview/dcategorizedview.cpp
M  +1    -0    libs/widgets/itemview/dcategorizedview.h

http://commits.kde.org/digikam/820c66bac12f1f0b00b4b1ba1deef5dc64d30397
Comment 19 caulier.gilles 2015-07-01 07:48:00 UTC
Git commit dbca06a5b5fdab7856b04c2d6325ec78b9b61ed4 by Gilles Caulier.
Committed on 01/07/2015 at 07:47.
Pushed by cgilles into branch 'frameworks'.

backport commit #820c66bac12f1f0b00b4b1ba1deef5dc64d30397 from git/master to frameworks branch
Related: bug 344952

M  +10   -0    libs/widgets/itemview/itemviewcategorized.cpp
M  +1    -0    libs/widgets/itemview/itemviewcategorized.h

http://commits.kde.org/digikam/dbca06a5b5fdab7856b04c2d6325ec78b9b61ed4
Comment 20 Greg4b 2017-01-16 06:06:45 UTC
sorry, but in 5.4 the desired behaviour - item focus in fixed in the middle - is not working.

In Linux 5.4 the focus moves to the outer area of right (or left) - this behaviour is undesired.
Comment 21 Maik Qualmann 2017-01-16 07:01:58 UTC
This option is optional and is disabled at default. Look in the settings-> miscellaneous.

Maik