Bug 337871 - deprecate --db-attach=yes in favor of --vgdb-error=1
Summary: deprecate --db-attach=yes in favor of --vgdb-error=1
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 00:22 UTC by John Reiser
Modified: 2014-09-01 06:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description John Reiser 2014-07-29 00:22:27 UTC 
--db-attach=yes has been obsoleted by --vgdb-error=1, and the --help should redirect non-expert users.

--- coregrind/m_main.c  (revision 14200)
+++ coregrind/m_main.c  (working copy)
@@ -131,7 +131,7 @@
 "                              load default suppressions [yes]\n"
 "    --suppressions=<filename> suppress errors described in <filename>\n"
 "    --gen-suppressions=no|yes|all    print suppressions for errors? [no]\n"
-"    --db-attach=no|yes        start debugger when errors detected? [no]\n"
+"    --db-attach=no|yes        deprecated; use --vgdb-debug=1 instead\n"
 "    --db-command=<command>    command to start debugger [%s -nw %%f %%p]\n"
 "    --input-fd=<number>       file descriptor for input [0=stdin]\n"
 "    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [no]\n"
Comment 1 John Reiser 2014-07-29 00:59:41 UTC 
The word should be "--vgdb-error" as in:

+"    --db-attach=no|yes        deprecated; use --vgdb-error=1 instead\n"
Comment 2 Florian Krohm 2014-07-30 09:50:09 UTC 
I support this. The vgdb machinery is superior and actively maintained.

Deprecation of the feature needs to be mentioned in the release notes so we can throw out the code in the release after next.
Comment 3 Florian Krohm 2014-09-01 06:37:53 UTC 
Fixed in r14401.