Bug 337522 - Get rid of KF5 port FIXMEs in the code
Summary: Get rid of KF5 port FIXMEs in the code
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: frameworks
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 337512
  Show dependency treegraph
 
Reported: 2014-07-16 22:49 UTC by Eike Hein
Modified: 2014-11-29 15:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-07-16 22:49:19 UTC
At the time of this writing there's numerous places in the code marked with "FIXME KF5 port", mostly disabled bits and some things that need testing. We want to get rid of all of them before shipping. Please CC this ticket when you commit a fix.
Comment 1 Peter Simonsson 2014-07-19 07:08:21 UTC
Git commit 1ebbb05437fcbd48d588c91e0cae07b33b6a7e05 by Peter Simonsson.
Committed on 19/07/2014 at 07:06.
Pushed by psn into branch 'frameworks'.

KLineEdit::setClickMessage -> QLineEdit::setPlaceholderText

M  +1    -1    src/irc/channellistpanelui.ui
M  +1    -1    src/viewer/channeloptionsdialog.cpp

http://commits.kde.org/konversation/1ebbb05437fcbd48d588c91e0cae07b33b6a7e05
Comment 2 Peter Simonsson 2014-07-19 19:16:09 UTC
Git commit 2def2db3c5a8355aaea16fb5c4465be106e611cc by Peter Simonsson.
Committed on 19/07/2014 at 18:44.
Pushed by psn into branch 'frameworks'.

Reenable open with action in irc context menus

M  +1    -1    src/viewer/irccontextmenus.cpp

http://commits.kde.org/konversation/2def2db3c5a8355aaea16fb5c4465be106e611cc
Comment 3 Peter Simonsson 2014-07-20 12:37:08 UTC
Git commit 7e7e53fd887bfc4e93008ab1a9d4e2a4bd1f0e9f by Peter Simonsson.
Committed on 20/07/2014 at 12:35.
Pushed by psn into branch 'frameworks'.

Reenable creation of leds

M  +9    -2    src/viewer/images.cpp

http://commits.kde.org/konversation/7e7e53fd887bfc4e93008ab1a9d4e2a4bd1f0e9f
Comment 4 Peter Simonsson 2014-07-20 12:57:24 UTC
Bah for got CCBUG on this:
commit 60946ad0dfd3035eef869b70689669e3b0328c4c
Author: Peter Simonsson <peter.simonsson@gmail.com>
Date:   Sun Jul 20 14:51:53 2014 +0200

    Reenable context menu on tray icon
Comment 5 Peter Simonsson 2014-07-20 13:11:15 UTC
Git commit f387d71866c13b16da1505b5a482ab632c0451a5 by Peter Simonsson.
Committed on 20/07/2014 at 13:10.
Pushed by psn into branch 'frameworks'.

Reenable the SSL icon

M  +2    -2    src/statusbar.cpp

http://commits.kde.org/konversation/f387d71866c13b16da1505b5a482ab632c0451a5
Comment 6 Peter Simonsson 2014-07-20 13:25:50 UTC
Git commit a93ec5748d7f84a783bd0d0758356d416dea4246 by Peter Simonsson.
Committed on 20/07/2014 at 13:24.
Pushed by psn into branch 'frameworks'.

Reenable menu titles for irc conext menus

Not that there are all that many styles that show them.

M  +2    -24   src/viewer/irccontextmenus.cpp

http://commits.kde.org/konversation/a93ec5748d7f84a783bd0d0758356d416dea4246
Comment 7 Peter Simonsson 2014-08-09 11:38:40 UTC
Git commit 0b580eac0ee61012928191a2c3b6cea1e0f40c12 by Peter Simonsson.
Committed on 09/08/2014 at 11:38.
Pushed by psn into branch 'frameworks'.

Reenable filedrops in the nicklist

M  +1    -3    src/irc/nicklistview.cpp

http://commits.kde.org/konversation/0b580eac0ee61012928191a2c3b6cea1e0f40c12
Comment 8 Peter Simonsson 2014-08-09 18:01:26 UTC
Git commit 17a9b19d1db1d45557f0467317e94442a861abb5 by Peter Simonsson.
Committed on 09/08/2014 at 18:01.
Pushed by psn into branch 'frameworks'.

Fix droping files on an query

M  +2    -3    src/viewer/ircview.cpp

http://commits.kde.org/konversation/17a9b19d1db1d45557f0467317e94442a861abb5
Comment 9 Peter Simonsson 2014-08-09 18:22:40 UTC
Git commit e7bdb7e55b436033a5e8e40453bc516875574ac0 by Peter Simonsson.
Committed on 09/08/2014 at 18:22.
Pushed by psn into branch 'frameworks'.

Reenable DCC chat in ircview

M  +4    -4    src/viewer/ircview.cpp
M  +1    -1    src/viewer/ircview.h

http://commits.kde.org/konversation/e7bdb7e55b436033a5e8e40453bc516875574ac0
Comment 10 Peter Simonsson 2014-08-11 16:20:25 UTC
Git commit b2bd6770c11e19543761e30f2c755b6c8778fe56 by Peter Simonsson.
Committed on 11/08/2014 at 16:20.
Pushed by psn into branch 'frameworks'.

Reenable loading of background image in ircview

M  +1    -3    src/viewer/ircview.cpp

http://commits.kde.org/konversation/b2bd6770c11e19543761e30f2c755b6c8778fe56
Comment 11 Peter Simonsson 2014-08-13 16:11:46 UTC
Git commit 1be1caa87867b01c54da394fe4613ec659d48b21 by Peter Simonsson.
Committed on 13/08/2014 at 16:10.
Pushed by psn into branch 'frameworks'.

Remove KRegExpEditor code that has been disabled since 2009

M  +1    -52   src/config/autoreplace_config.cpp
M  +0    -1    src/config/autoreplace_config.h
M  +26   -38   src/config/autoreplace_configui.ui
M  +0    -49   src/config/highlight_config.cpp
M  +0    -1    src/config/highlight_config.h
M  +57   -74   src/config/highlight_configui.ui

http://commits.kde.org/konversation/1be1caa87867b01c54da394fe4613ec659d48b21
Comment 12 Peter Simonsson 2014-08-13 16:16:15 UTC
Git commit 523fa577d0181a0c36e5890f4119269755cba452 by Peter Simonsson.
Committed on 13/08/2014 at 16:16.
Pushed by psn into branch 'frameworks'.

Reenable DCC transfer check on quit

M  +1    -2    src/mainwindow.cpp

http://commits.kde.org/konversation/523fa577d0181a0c36e5890f4119269755cba452
Comment 13 Peter Simonsson 2014-08-13 16:45:06 UTC
Git commit b52c3d2377d78b37fac944202c97e5d3a1550f95 by Peter Simonsson.
Committed on 13/08/2014 at 16:44.
Pushed by psn into branch 'frameworks'.

Reenable icon on close button in tabbar

M  +2    -1    src/viewer/viewcontainer.cpp

http://commits.kde.org/konversation/b52c3d2377d78b37fac944202c97e5d3a1550f95
Comment 14 Peter Simonsson 2014-08-13 19:04:28 UTC
Git commit ed35338b104648b5507134570d458163e6243203 by Peter Simonsson.
Committed on 13/08/2014 at 19:04.
Pushed by psn into branch 'frameworks'.

Reenable external log viewer support

M  +1    -1    src/viewer/viewcontainer.cpp

http://commits.kde.org/konversation/ed35338b104648b5507134570d458163e6243203
Comment 15 Peter Simonsson 2014-08-22 15:55:57 UTC
Git commit 259a8727372d602b0d7740182d95456c34811adf by Peter Simonsson.
Committed on 22/08/2014 at 15:53.
Pushed by psn into branch 'frameworks'.

Port to QFileDialog::get*

M  +0    -4    src/config/highlight_config.cpp
M  +4    -5    src/config/theme_config.cpp
M  +0    -1    src/dcc/resumedialog.cpp
M  +2    -4    src/irc/channellistpanel.cpp
M  +4    -4    src/urlcatcher.cpp
M  +2    -3    src/viewer/irccontextmenus.cpp
M  +4    -8    src/viewer/logfilereader.cpp

http://commits.kde.org/konversation/259a8727372d602b0d7740182d95456c34811adf
Comment 16 Peter Simonsson 2014-08-22 17:39:39 UTC
Git commit ed7dc7dbdce8c439340f34de445e59ec1a7390ce by Peter Simonsson.
Committed on 22/08/2014 at 17:39.
Pushed by psn into branch 'frameworks'.

Enable QT_NO_URL_CAST_FROM_STRING and QT_NO_CAST_FROM_BYTEARRAY

M  +2    -2    CMakeLists.txt
M  +1    -1    src/bookmarkhandler.cpp
M  +2    -2    src/config/highlight_config.cpp
M  +2    -2    src/config/theme_config.cpp
M  +2    -2    src/dcc/resumedialog.cpp
M  +1    -1    src/dcc/transferdetailedinfopanel.cpp
M  +2    -2    src/dcc/transferrecv.cpp
M  +1    -1    src/irc/server.cpp
M  +1    -1    src/unicode.cpp
M  +1    -1    src/upnp/upnpmcastsocket.cpp
M  +2    -2    src/urlcatcher.cpp
M  +1    -1    src/viewer/irccontextmenus.cpp

http://commits.kde.org/konversation/ed7dc7dbdce8c439340f34de445e59ec1a7390ce
Comment 17 Peter Simonsson 2014-08-23 12:49:50 UTC
Git commit 5e254fcd9dd0e07d3dd8ffe836e38030dbd75411 by Peter Simonsson.
Committed on 23/08/2014 at 12:49.
Pushed by psn into branch 'frameworks'.

Add KGlobalAccel support

M  +1    -0    CMakeLists.txt
M  +1    -0    src/CMakeLists.txt
M  +3    -2    src/mainwindow.cpp

http://commits.kde.org/konversation/5e254fcd9dd0e07d3dd8ffe836e38030dbd75411
Comment 18 Peter Simonsson 2014-08-23 13:06:14 UTC
Git commit 148c21b438a8aa05bee40ca821894ce382518274 by Peter Simonsson.
Committed on 23/08/2014 at 13:06.
Pushed by psn into branch 'frameworks'.

Clean up includes

M  +0    -4    src/config/preferences.h
M  +2    -0    src/irc/nickinfo.cpp
M  +2    -0    src/irc/outputfilter.cpp
M  +0    -7    src/irc/server.h
M  +1    -0    src/viewer/irccontextmenus.cpp
M  +1    -0    src/viewer/ircinput.cpp
M  +2    -0    src/viewer/ircview.cpp
M  +1    -0    src/viewer/topiclabel.cpp
M  +1    -0    src/viewer/viewspringloader.cpp

http://commits.kde.org/konversation/148c21b438a8aa05bee40ca821894ce382518274
Comment 19 Peter Simonsson 2014-08-23 16:57:24 UTC
Git commit 483a9f31254cbfe94872fa6560b64b35313b6829 by Peter Simonsson.
Committed on 23/08/2014 at 16:56.
Pushed by psn into branch 'frameworks'.

Start enclosing in QStringLiteral and QLatin1Char

M  +70   -70   src/application.cpp
M  +3    -3    src/awaymanager.cpp
M  +4    -4    src/bookmarkhandler.cpp
M  +33   -33   src/common.cpp
M  +5    -5    src/common.h
M  +26   -26   src/config/preferences.cpp
M  +26   -26   src/connectionmanager.cpp
M  +9    -9    src/dbus.cpp
M  +7    -7    src/identity.cpp
M  +15   -15   src/identitydialog.cpp
M  +51   -51   src/irc/channel.cpp
M  +11   -11   src/irc/channellistpanel.cpp
M  +1    -1    src/irc/channelnick.cpp
M  +201  -201  src/irc/inputfilter.cpp
M  +13   -13   src/irc/invitedialog.cpp
M  +16   -16   src/irc/irccharsets.cpp
M  +1    -1    src/irc/joinchanneldialog.cpp
M  +7    -7    src/irc/nick.cpp
M  +23   -23   src/irc/nicksonline.cpp
M  +9    -9    src/irc/outputfilter.cpp
M  +9    -9    src/irc/query.cpp
M  +132  -133  src/irc/server.cpp
M  +2    -2    src/irc/topichistorymodel.cpp
M  +2    -2    src/konsolepanel.cpp
M  +131  -131  src/mainwindow.cpp
M  +18   -18   src/notificationhandler.cpp
M  +2    -2    src/queuetuner.cpp
M  +3    -3    src/quickconnectdialog.cpp
M  +5    -5    src/scriptlauncher.cpp
M  +1    -1    src/sound.cpp
M  +1    -1    src/sound.h
M  +7    -7    src/statusbar.cpp
M  +1    -1    src/unicode.cpp
M  +12   -12   src/urlcatcher.cpp

http://commits.kde.org/konversation/483a9f31254cbfe94872fa6560b64b35313b6829
Comment 20 Peter Simonsson 2014-08-24 11:58:57 UTC
Git commit 90449cd3f4e4bd0afbcf3b4792b6f6677d1e030a by Peter Simonsson.
Committed on 24/08/2014 at 11:58.
Pushed by psn into branch 'frameworks'.

Remove KF5::BalooWidgets from target_link_libraries

M  +0    -1    src/CMakeLists.txt

http://commits.kde.org/konversation/90449cd3f4e4bd0afbcf3b4792b6f6677d1e030a
Comment 21 Peter Simonsson 2014-08-24 14:44:50 UTC
Git commit 377d5fe05e8ecf22ebd25a8a23cb0903692f3d1d by Peter Simonsson.
Committed on 24/08/2014 at 14:44.
Pushed by psn into branch 'frameworks'.

Remove app icon install that isn't needed anymore

M  +0    -2    src/CMakeLists.txt

http://commits.kde.org/konversation/377d5fe05e8ecf22ebd25a8a23cb0903692f3d1d
Comment 22 Peter Simonsson 2014-08-24 15:19:33 UTC
Git commit 37b21e17f5572d9ba3b2d1506e13191d80c8b5fe by Peter Simonsson.
Committed on 24/08/2014 at 15:19.
Pushed by psn into branch 'frameworks'.

Add isLocalFile check for log file

M  +8    -1    src/viewer/chatwindow.cpp

http://commits.kde.org/konversation/37b21e17f5572d9ba3b2d1506e13191d80c8b5fe
Comment 23 Eike Hein 2014-11-23 23:33:46 UTC
Git commit 6e88fe15966cfb724cea0925cdff3ad39b22c251 by Eike Hein.
Committed on 23/11/2014 at 22:23.
Pushed by hein into branch 'frameworks'.

Works.

M  +1    -1    src/irc/query.cpp

http://commits.kde.org/konversation/6e88fe15966cfb724cea0925cdff3ad39b22c251
Comment 24 Eike Hein 2014-11-29 15:26:20 UTC
All of the remaining FIXMEs are covered by other bugs, except for a trivial QCA-related build system flag - closing for upkeep.