Bug 337518 - Get rid of KDELibs4Support
Summary: Get rid of KDELibs4Support
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (other bugs)
Version First Reported In: frameworks
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on: 337519 337520
Blocks: 337512
  Show dependency treegraph
 
Reported: 2014-07-16 22:46 UTC by Eike Hein
Modified: 2014-11-29 15:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-07-16 22:46:06 UTC
Add --kdelibs4support porting items as dependencies to this bug.
Comment 1 Peter Simonsson 2014-10-31 20:21:39 UTC
Git commit 75795797fcfb2e90ad9ede511df29d1a98abc73b by Peter Simonsson.
Committed on 31/10/2014 at 18:55.
Pushed by psn into branch 'frameworks'.

KDialog--

M  +7    -6    src/config/konversation.kcfg

http://commits.kde.org/konversation/75795797fcfb2e90ad9ede511df29d1a98abc73b
Comment 2 Peter Simonsson 2014-10-31 20:21:41 UTC
Git commit 86fe8f7b149062e13174b7a6b680e1fc6956e778 by Peter Simonsson.
Committed on 31/10/2014 at 20:05.
Pushed by psn into branch 'frameworks'.

Remove some uses of KLocale, KGlobal and KGlobalSettings

M  +4    -0    CMakeLists.txt
M  +4    -0    src/CMakeLists.txt
M  +1    -1    src/application.cpp
M  +0    -1    src/application.h
M  +1    -2    src/konsolepanel.cpp
M  +2    -2    src/mainwindow.cpp
M  +1    -3    src/scriptlauncher.cpp
M  +2    -4    src/urlcatcher.cpp

http://commits.kde.org/konversation/86fe8f7b149062e13174b7a6b680e1fc6956e778
Comment 3 Peter Simonsson 2014-11-01 09:15:41 UTC
Git commit 163e320cb5bcdce2574d818375a87ad75c6fd8ae by Peter Simonsson.
Committed on 01/11/2014 at 09:14.
Pushed by psn into branch 'frameworks'.

Use KFileWidget for DCCFileDialog

Instead of subclassing KFileDialog that is in KDELibs4Support use
QDialog and KFileWidget.

M  +27   -12   src/dcc/dccfiledialog.cpp
M  +9    -3    src/dcc/dccfiledialog.h
M  +1    -1    src/irc/server.cpp

http://commits.kde.org/konversation/163e320cb5bcdce2574d818375a87ad75c6fd8ae
Comment 4 Eike Hein 2014-11-29 15:13:20 UTC
We're rid of it!