Bug 337516 - ViewTree ("tabs on left") lacks separator item
Summary: ViewTree ("tabs on left") lacks separator item
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: frameworks
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 337512
  Show dependency treegraph
 
Reported: 2014-07-16 22:44 UTC by Eike Hein
Modified: 2015-04-03 22:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-07-16 22:44:38 UTC
Needs rewrite. This one's mine.
Comment 1 Eike Hein 2014-07-18 03:21:56 UTC
Git commit 469a84e0e49b6ea895c284de81ec2cc0f5cf7ed4 by Eike Hein.
Committed on 18/07/2014 at 03:18.
Pushed by hein into branch 'frameworks'.

Start reimplementing ViewTree.

What works:
- Basic mouse/wheel/keyboard interaction.
- Context menu.
- Keyboard event forwarding to views.
- Spring loading on drag hover.
- Notification colors (no icons yet, the led engine is unported).

What doesn't:
- Not actually a tree yet.
- Custom delegate appearance.
- Seperator item.
- DND.
- Close buttons.
- Middle click close.

M  +1    -0    src/CMakeLists.txt
M  +40   -102  src/viewer/viewcontainer.cpp
M  +3    -3    src/viewer/viewcontainer.h
M  +9    -9    src/viewer/viewspringloader.cpp
M  +83   -879  src/viewer/viewtree.cpp
M  +33   -81   src/viewer/viewtree.h

http://commits.kde.org/konversation/469a84e0e49b6ea895c284de81ec2cc0f5cf7ed4
Comment 2 Eike Hein 2014-11-22 16:52:10 UTC
Update:

What works by now:
- Custom delegate appearance.

What I forgot that doesn't yet:
- Tooltips for items with elided labels.
Comment 3 Eike Hein 2014-11-22 17:03:48 UTC
Switching from tabs to tree at runtime makes the "&" accelerator stuff show up in tree labels.
Comment 4 Eike Hein 2014-11-22 17:19:30 UTC
Git commit dcc068aa777ef9f5c4d1b9f36f7377a93f774b3c by Eike Hein.
Committed on 22/11/2014 at 17:18.
Pushed by hein into branch 'frameworks'.

Implement middle-click close and don't raise on delegate context menu events.

M  +1    -0    src/viewer/viewcontainer.cpp
M  +38   -0    src/viewer/viewtree.cpp
M  +7    -2    src/viewer/viewtree.h

http://commits.kde.org/konversation/dcc068aa777ef9f5c4d1b9f36f7377a93f774b3c
Comment 5 Eike Hein 2014-11-22 17:33:50 UTC
Git commit 60ab015c7a14ea6ece9d69ade16d61e7e0b65e6c by Eike Hein.
Committed on 22/11/2014 at 17:31.
Pushed by hein into branch 'frameworks'.

Reimplement highlighting non-current items with the alt base color while ctxt menu is open.

M  +14   -6    src/viewer/viewcontainer.cpp
M  +2    -1    src/viewer/viewcontainer.h
M  +9    -1    src/viewer/viewtree.cpp

http://commits.kde.org/konversation/60ab015c7a14ea6ece9d69ade16d61e7e0b65e6c
Comment 6 Eike Hein 2014-11-23 23:33:44 UTC
Git commit f77d86003dc27a0847df61e50785907344957542 by Eike Hein.
Committed on 23/11/2014 at 22:09.
Pushed by hein into branch 'frameworks'.

Lots of ViewTree work.

- It's a tree again.
- Lots of delegate painting fixes.
- State constraints for the move up/down actions reflect hierarchy.

That leaves DND, tooltips, close buttons and the fancy seperator item ...

M  +4    -0    src/config/tabs_config.cpp
M  +5    -0    src/irc/channel.cpp
M  +2    -0    src/irc/channel.h
M  +0    -12   src/irc/outputfilter.cpp
M  +0    -1    src/irc/outputfilter.h
M  +5    -0    src/irc/query.cpp
M  +1    -0    src/irc/query.h
M  +5    -0    src/viewer/chatwindow.cpp
M  +1    -0    src/viewer/chatwindow.h
M  +3    -48   src/viewer/ircview.cpp
M  +5    -0    src/viewer/rawlog.cpp
M  +1    -0    src/viewer/rawlog.h
M  +281  -137  src/viewer/viewcontainer.cpp
M  +3    -6    src/viewer/viewcontainer.h
M  +85   -56   src/viewer/viewtree.cpp
M  +2    -3    src/viewer/viewtree.h

http://commits.kde.org/konversation/f77d86003dc27a0847df61e50785907344957542
Comment 7 Eike Hein 2014-11-23 23:33:48 UTC
Git commit bb342d0614f7c08b3c8e536bc4671f763b8114b0 by Eike Hein.
Committed on 23/11/2014 at 23:31.
Pushed by hein into branch 'frameworks'.

Show tooltips for elided items.

M  +42   -1    src/viewer/viewtree.cpp
M  +3    -9    src/viewer/viewtree.h

http://commits.kde.org/konversation/bb342d0614f7c08b3c8e536bc4671f763b8114b0
Comment 8 Eike Hein 2015-04-03 22:52:01 UTC
We've decided to deprecate the tab bar for 2.0 and focus on a redesign of the ViewTree, and that won't contain close buttons, which were only really there for parity with the tab bar - so dropping it from the bug description.