Bug 337356 - better integration: native file dialogs and unified title/toolbar
Summary: better integration: native file dialogs and unified title/toolbar
Alias: None
Product: kdelibs
Classification: Unclassified
Component: kdeui (show other bugs)
Version: 4.12.5
Platform: MacPorts Packages macOS
: NOR minor (vote)
Target Milestone: ---
Assignee: kdelibs bugs
URL: https://forum.kde.org/viewtopic.php?f...
Depends on:
Reported: 2014-07-11 11:01 UTC by RJVB
Modified: 2015-04-18 10:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

patch to enable native filedialogs by default (1.95 KB, patch)
2014-07-11 11:02 UTC, RJVB
patch that unifies title and toolbar (536 bytes, patch)
2014-07-11 11:02 UTC, RJVB

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2014-07-11 11:01:45 UTC
KDE's own file dialogs aren't the most useful on OS X. For better integration with the rest of the OS and restore drag-and-drop functionality, they should default to "native".

Reproducible: Always

Steps to Reproduce:
1. open file dialog in an application like kate, e.g. to open a file

Actual Results:  
note how the dialog is different from OS X dialogs, how it doesn't provide easy access to different mounted volumes, the history nor the drag-and-drop facility that allows one to select a file or move to a folder by simply dropping one onto the dialog.

Expected Results:  
it'd be nice to have the things mentioned above as missing

just setting Native=true under [KFileDialog Settings] in kglobalrc leads to distorted file dialogs. The webpage given above lists a few patches that I implemented.

I'm throwing in the patch to unify title and toolbars.
Comment 1 RJVB 2014-07-11 11:02:26 UTC
Created attachment 87687 [details]
patch to enable native filedialogs by default
Comment 2 RJVB 2014-07-11 11:02:56 UTC
Created attachment 87688 [details]
patch that unifies title and toolbar
Comment 3 RJVB 2014-07-11 11:05:19 UTC
NB1: not all applications appear to honour the type of dialog; for example kdenlive will use a KDE file dialog when selecting the Add Clip function. And it's distorted in that case.

NB2: couldn't get the patches accepted for a Review Request because they're not git diff patches?!
Comment 4 Christoph Feck 2014-07-11 11:37:27 UTC
TRUE -> true

If reviewboard did not work, you could also send a mail to kde-core-devel with a message there. On the other hand, we would prefer if someone of the KDE-on-Mac community with a KDE git developer account would simply commit those fixes after a review within the community, because the non-Mac developers cannot really decide if those integration patches are correct.
Comment 5 RJVB 2014-07-11 11:57:48 UTC
That latter options is indeed what I just suggested/asked on the kde-mac ML ...
Comment 6 Marko Käning 2014-07-12 10:00:37 UTC
I have posted this as an RR now [1].

[1] https://git.reviewboard.kde.org/r/119243/
Comment 7 Marko Käning 2014-07-12 10:56:57 UTC
The RR doesn't seem to solve the issue of distorted file dialogs...