There's lots of different naming styles for file, executable and class names for all the unit tests. This makes it hard to identify them when searching for classes via Quick Open or when looking up test binaries in the build folder. I'm proposing the following naming scheme: - test_foo.cpp (file name) - test_foo (target name) - TestFoo (class name) To be applied to all existing unit tests. Also see discussion at http://mail.kde.org/pipermail/kdevelop-devel/2014-July/048339.html. Reproducible: Always
Git commit db995e41c32bc09544eb33a4dd2465dc0e75b4f8 by Kevin Funk, on behalf of Laurent Navet. Committed on 19/08/2014 at 15:27. Pushed by kfunk into branch 'frameworks'. Consistent naming scheme for unit test Changes: * Rename .cpp .h and target from footest or whatever to test_foo * Rename class from FooTest to TestFoo * Adapt headers guardians if needed REVIEW: 119795 M +7 -7 interfaces/tests/CMakeLists.txt M +5 -5 language/backgroundparser/tests/CMakeLists.txt M +5 -5 language/codegen/tests/CMakeLists.txt M +18 -18 language/duchain/tests/CMakeLists.txt R +15 -16 language/duchain/tests/test_benchhashes.cpp [from: language/duchain/tests/benchhashes.cpp - 092% similarity] R +4 -4 language/duchain/tests/test_benchhashes.h [from: language/duchain/tests/benchhashes.h - 087% similarity] R +2 -2 language/duchain/tests/test_duchainshutdown.cpp [from: language/duchain/tests/tst_duchainshutdown.cpp - 097% similarity] R +2 -2 language/duchain/tests/test_duchainshutdown.h [from: language/duchain/tests/tst_duchainshutdown.h - 092% similarity] M +5 -5 language/highlighting/tests/CMakeLists.txt M +5 -5 plugins/git/tests/CMakeLists.txt R +1 -1 plugins/git/tests/test_git.cpp [from: plugins/git/tests/gittest.cpp - 099% similarity] R +0 -0 plugins/git/tests/test_git.h [from: plugins/git/tests/gittest.h - 100% similarity] M +5 -5 plugins/grepview/tests/CMakeLists.txt R +18 -18 plugins/grepview/tests/test_findreplace.cpp [from: plugins/grepview/tests/findreplacetest.cpp - 096% similarity] R +5 -5 plugins/grepview/tests/test_findreplace.h [from: plugins/grepview/tests/findreplacetest.h - 098% similarity] M +4 -4 plugins/projectfilter/tests/CMakeLists.txt M +12 -12 plugins/quickopen/tests/CMakeLists.txt R +10 -11 plugins/quickopen/tests/test_quickopen.cpp [from: plugins/quickopen/tests/quickopentest.cpp - 096% similarity] R +5 -5 plugins/quickopen/tests/test_quickopen.h [from: plugins/quickopen/tests/quickopentest.h - 083% similarity] R +14 -15 plugins/quickopen/tests/test_quickopenbench.cpp [from: plugins/quickopen/tests/quickopenbench.cpp - 081% similarity] R +5 -5 plugins/quickopen/tests/test_quickopenbench.h [from: plugins/quickopen/tests/quickopenbench.h - 085% similarity] M +6 -6 plugins/standardoutputview/tests/CMakeLists.txt R +1 -1 plugins/standardoutputview/tests/test_standardoutputview.cpp [from: plugins/standardoutputview/tests/standardoutputviewtest.cpp - 099% similarity] R +3 -3 plugins/standardoutputview/tests/test_standardoutputview.h [from: plugins/standardoutputview/tests/standardoutputviewtest.h - 090% similarity] M +6 -6 project/tests/CMakeLists.txt R +25 -25 project/tests/test_projectmodel.cpp [from: project/tests/projectmodeltest.cpp - 095% similarity] R +3 -3 project/tests/test_projectmodel.h [from: project/tests/projectmodeltest.h - 094% similarity] M +5 -5 serialization/tests/CMakeLists.txt M +35 -35 shell/tests/CMakeLists.txt R +13 -14 shell/tests/test_documentcontroller.cpp [from: shell/tests/documentcontrollertest.cpp - 089% similarity] R +4 -4 shell/tests/test_documentcontroller.h [from: shell/tests/documentcontrollertest.h - 089% similarity] R +10 -10 shell/tests/test_plugincontroller.cpp [from: shell/tests/plugincontrollertest.cpp - 091% similarity] R +4 -4 shell/tests/test_plugincontroller.h [from: shell/tests/plugincontrollertest.h - 089% similarity] R +16 -17 shell/tests/test_sessioncontroller.cpp [from: shell/tests/sessioncontrollertest.cpp - 093% similarity] R +4 -4 shell/tests/test_sessioncontroller.h [from: shell/tests/sessioncontrollertest.h - 090% similarity] R +13 -14 shell/tests/test_shellbuddy.cpp [from: shell/tests/shellbuddytest.cpp - 096% similarity] R +3 -4 shell/tests/test_shellbuddy.h [from: shell/tests/shellbuddytest.h - 094% similarity] R +13 -14 shell/tests/test_shelldocumentoperation.cpp [from: shell/tests/shelldocumentoperationtest.cpp - 090% similarity] R +3 -4 shell/tests/test_shelldocumentoperation.h [from: shell/tests/shelldocumentoperationtest.h - 091% similarity] R +10 -10 shell/tests/test_testcontroller.cpp [from: shell/tests/testcontrollertest.cpp - 094% similarity] R +4 -4 shell/tests/test_testcontroller.h [from: shell/tests/testcontrollertest.h - 088% similarity] R +5 -6 shell/tests/test_uicontroller.cpp [from: shell/tests/uicontrollertest.cpp - 090% similarity] R +4 -4 shell/tests/test_uicontroller.h [from: shell/tests/uicontrollertest.h - 085% similarity] M +40 -40 sublime/tests/CMakeLists.txt M +2 -2 sublime/tests/areaprinter.h R +4 -5 sublime/tests/test_aggregatemodel.cpp [from: sublime/tests/aggregatemodeltest.cpp - 093% similarity] R +3 -4 sublime/tests/test_aggregatemodel.h [from: sublime/tests/aggregatemodeltest.h - 092% similarity] R +21 -22 sublime/tests/test_areaoperation.cpp [from: sublime/tests/areaoperationtest.cpp - 096% similarity] R +3 -4 sublime/tests/test_areaoperation.h [from: sublime/tests/areaoperationtest.h - 094% similarity] R +4 -5 sublime/tests/test_areawalker.cpp [from: sublime/tests/areawalkertest.cpp - 097% similarity] R +3 -4 sublime/tests/test_areawalker.h [from: sublime/tests/areawalkertest.h - 092% similarity] R +5 -6 sublime/tests/test_controller.cpp [from: sublime/tests/controllertest.cpp - 095% similarity] R +3 -4 sublime/tests/test_controller.h [from: sublime/tests/controllertest.h - 092% similarity] R +3 -4 sublime/tests/test_document.cpp [from: sublime/tests/documenttest.cpp - 095% similarity] R +3 -4 sublime/tests/test_document.h [from: sublime/tests/documenttest.h - 092% similarity] R +11 -11 sublime/tests/test_toolviewtoolbar.cpp [from: sublime/tests/toolviewtoolbartest.cpp - 090% similarity] R +3 -3 sublime/tests/test_toolviewtoolbar.h [from: sublime/tests/toolviewtoolbartest.h - 094% similarity] R +8 -8 sublime/tests/test_view.cpp [from: sublime/tests/viewtest.cpp - 089% similarity] R +3 -4 sublime/tests/test_view.h [from: sublime/tests/viewtest.h - 093% similarity] R +10 -10 sublime/tests/test_viewactivation.cpp [from: sublime/tests/viewactivationtest.cpp - 094% similarity] R +3 -4 sublime/tests/test_viewactivation.h [from: sublime/tests/viewactivationtest.h - 094% similarity] M +1 -1 tests/modeltest.cpp M +12 -12 util/tests/CMakeLists.txt M +5 -5 vcs/dvcs/tests/CMakeLists.txt R +5 -6 vcs/dvcs/tests/test_dvcsjob.cpp [from: vcs/dvcs/tests/dvcsjobTest.cpp - 094% similarity] R +3 -3 vcs/dvcs/tests/test_dvcsjob.h [from: vcs/dvcs/tests/dvcsjobTest.h - 093% similarity] M +5 -5 vcs/models/tests/CMakeLists.txt R +5 -5 vcs/models/tests/test_models.cpp [from: vcs/models/tests/modelstest.cpp - 096% similarity] R +4 -4 vcs/models/tests/test_models.h [from: vcs/models/tests/modelstest.h - 091% similarity] http://commits.kde.org/kdevplatform/db995e41c32bc09544eb33a4dd2465dc0e75b4f8
Fixed in https://projects.kde.org/projects/extragear/kdevelop/kdevplatform/repository/revisions/db995e41c32bc09544eb33a4dd2465dc0e75b4f8
Thanks. Keep on rocking!