Bug 337117 - remote:/ kioslave can't launch knetattach
Summary: remote:/ kioslave can't launch knetattach
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-05 13:51 UTC by Eike Hein
Modified: 2014-07-07 18:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-07-05 13:51:38 UTC
I'm putting this into frameworks-kio because I'm not sure what the best product for a kioslave in workspace would be and this has the best chance of reaching knowledgable parties, I guess.

We have the remote:/ kioslave in plasma-workspace. Its top-level dir listing contains a "Add Network Folder" entry to launch knetattach. It works by creating a KIO::UDSEntry pointing at knetattach's .desktop file (using a combination of KService::serviceByDesktopName and KStandardDirs::locate("apps", ...) for lookup).

Actually executing this entry doesn't work anymore, because knetattach is installed in libexec, and the .desktop execution machinery can't find executables there, probably because it was ported to QStandardPaths::findExecutable, which doesn't look there.

Porting notes specify to hardcode CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR in cases like this, but the kioslave doesn't afford an opportunity for it since it currently doesn't handle execution.

How do we want to fix this? Do we want to move knetattach to the regular executable dir? Note that it's also shown in launchers, so running it from there presently doesn't work either.

Reproducible: Always
Comment 1 Eike Hein 2014-07-05 13:52:06 UTC
Adding Marco to have the workspace maintainer in the loop.
Comment 2 David Faure 2014-07-06 22:14:58 UTC
I don't know much about knetattach, but if it should be shown in launchers like the K menu, then obviously it should be in bin, not in libexec.
Comment 3 Eike Hein 2014-07-07 11:33:12 UTC
Reviewing at https://git.reviewboard.kde.org/r/119154/
Comment 4 Eike Hein 2014-07-07 18:20:15 UTC
Git commit e9d2ae77734df72dea1e3b610907c28f838dbb2e by Eike Hein.
Committed on 07/07/2014 at 18:18.
Pushed by hein into branch 'master'.

Install knetattach regularly instead of into libexec.

Fixes launcher entry and reference in remote:/.

Reviewed-by: Aleix Pol
REVIEW:119154

M  +1    -2    knetattach/CMakeLists.txt

http://commits.kde.org/plasma-desktop/e9d2ae77734df72dea1e3b610907c28f838dbb2e