Bug 337055 - desktop toolbox scales with font size
Summary: desktop toolbox scales with font size
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: unspecified Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-04 13:21 UTC by Harald Sitter
Modified: 2014-07-11 11:17 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot 16pt (570.49 KB, image/png)
2014-07-04 13:22 UTC, Harald Sitter
Details
screenshot 10pt (554.55 KB, image/png)
2014-07-04 13:22 UTC, Harald Sitter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2014-07-04 13:21:45 UTC
The toolbox as by default shown in the top-left corner of plasmashell scales its rectangle size with font size.

So, if one increases the fontsize to (e.g.) 16pt and restarts plasma the toolbox will be notibly bigger than it was at 10pt. This is worsened by the fact that the actual icon of the toolbox does not get scaled thus looking very weird.

Reproducible: Always
Comment 1 Harald Sitter 2014-07-04 13:22:13 UTC
Created attachment 87540 [details]
screenshot 16pt
Comment 2 Harald Sitter 2014-07-04 13:22:51 UTC
Created attachment 87541 [details]
screenshot 10pt
Comment 3 David Edmundson 2014-07-04 15:38:37 UTC
Plasma bases a lot of things on the font size as a crude way of determining DPI.

Why do you have such a huge font on that size screen anyway?
Comment 4 Harald Sitter 2014-07-04 15:46:25 UTC
short answer: because it's possible

long answer: http://en.wikipedia.org/wiki/Stargardt_disease and generally any visual impairment where larger fonts help readability
Comment 5 David Edmundson 2014-07-04 15:50:19 UTC
The short answer is not very convincing.

As for the longer argument, one argument behind the choice of using font is that "if you need to make the fonts bigger, you'd want everything else bigger too"

Is that not true?
Comment 6 Harald Sitter 2014-07-04 15:54:07 UTC
Yes, but the thing is everything else isn't bigger. The frame is bigger, the icon is not, so that does next to nothing for accessibility. I'll gladly agree with a fix that makes the icon scale proportional to the frame though :)
Comment 7 David Edmundson 2014-07-04 16:37:42 UTC
OK, cool. Confirming.
Comment 8 Marco Martin 2014-07-07 08:25:09 UTC
It's intended to me this way, but the icon should scale too.
also, everything is using units.gridUnit that right now is based purely on the font size.
it should be based instead on proper dpi.
I feel the proper solution can come only with (probably Qt 5.4?) when the highdpi branch is merged, so there is an unified way to scale the ui
Comment 9 Aleix Pol 2014-07-08 14:16:19 UTC
Git commit e38dc4f0dadd5ca40f34e4ba538eedd23c594e92 by Aleix Pol.
Committed on 08/07/2014 at 14:15.
Pushed by apol into branch 'master'.

Adapt icon size to toolbox size

Instead of using the internal iconSize, use the toolbox's size.

M  +2    -2    toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

http://commits.kde.org/plasma-desktop/e38dc4f0dadd5ca40f34e4ba538eedd23c594e92
Comment 10 David Edmundson 2014-07-11 11:17:24 UTC
Git commit 177ba4e5d10f788f267791ca5782e44ae861df64 by David Edmundson.
Committed on 11/07/2014 at 10:25.
Pushed by davidedmundson into branch 'Plasma/5.0'.

Remove completley wrong changes to ToolboxButton

Adapt iconsize to toolbox size introduces a blatant binding loop
It was changed to be 0.8 of the frame, but the frame was based on the icon size

The binding loop was then "fixed" by wrapping in an item which doesn't fix the
root problem of it being a loop.

The iconSize comes from units.iconSize.Small in ToolBoxRoot in the first place, making
the entire change pointless. If we do want to scale the icon we just need to change that
one line in ToolBoxRoot.

We certainly don't want to make changes that leave stray unused properties about.

Revert "remove undetected binding loop"

This reverts commit eddb56e5a7cac3cd631f1cb8e315af02f57779ee.

Revert "use standard icons sizes for the toolbox icon"

This reverts commit 216ee387648f7105561dabcf33d06ec880be65a3.

Revert "Adapt icon size to toolbox size"

This reverts commit e38dc4f0dadd5ca40f34e4ba538eedd23c594e92.
Related: bug 336441
REVIEW: 119229

M  +16   -34   toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

http://commits.kde.org/plasma-desktop/177ba4e5d10f788f267791ca5782e44ae861df64