Mouse Mark is a great effect, but it looks quite ugly. Could you implement some sort of smoothing? At least antialiasing, but also general smoothing of the shape would be nice. http://i.imgur.com/Dnz6Yfr.png Reproducible: Always
Git commit 99804e0233cbb1054b1b1f5148dc5c7a6833a709 by Vlad Zagorodniy. Committed on 09/08/2018 at 19:52. Pushed by vladz into branch 'master'. [effects/mousemark] Properly use GL_LINE_SMOOTH Summary: We need to enable GL_BLEND for line smoothing to work. Test Plan: Before: {F6184072, layout=center, size=full} After: {F6184074, layout=center, size=full} Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14714 M +5 -0 effects/mousemark/mousemark.cpp https://commits.kde.org/kwin/99804e0233cbb1054b1b1f5148dc5c7a6833a709
OpenGL line smoothing is not really good. It would be great to use QPainter to draw lines. I've tried today to use an overlay window to draw mouse marks: https://github.com/zzag/kwin/tree/qml-mousemark-effect It kinda works https://photos.app.goo.gl/eLWMphR8xRqqjGmQ6 but I don't have much time to finish work on that patch.