Bug 336899 - JJ "activate next/previous layer" shorcut
Summary: JJ "activate next/previous layer" shorcut
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-06-30 12:01 UTC by Bollebib
Modified: 2017-02-06 13:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
enter groups with activateNextNode/activatePreviousNode (898 bytes, patch)
2015-07-11 18:32 UTC, g6793396
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2014-06-30 12:01:11 UTC
"activate next/previous layer" shorcut already exists,but I propose an alternate version that should also be present.

The function as we have it works well,but skips groups entirely when it encounters them.
I propose a seperate other function that works like the  Qt layerbox shorcut.

Select layerbox
press up arrow/down arrow
->the layers get selected as expected,without skipping some layers.

This does however not work on canvas. 
So when on canvas the shortcut should also be recognized.




13:27:21 - Bollebib: When you use arrows up and down in layer box it selects like I would expect
13:27:36 - Bollebib: 1 space up and down each time
13:27:36 - Bollebib: this does not seem to be the same as activate next/previous layer which jumps from group to group and ignores group contents when present
13:28:00 - Bollebib: and when on canvas you can't use the arrows up and down as it is then used for nudging the canvas,which is arguably expected,but in that case I would expect those 2 seperate features not share the same shortcuts
13:28:00 - Bollebib: is there a way for me to access those functions and change the shortcuts in the settings?
13:28:23 - boud: Bollebib: aren't they in the shortcuts dialog?
13:28:54 - Bollebib: boud: the only ones I found work as I described,they skip between groups,they don't work the same
13:29:05 - boud: ah, wait
13:29:23 - boud: in the layerbox, arrow up and down isn't a shortcut... it's just what the Qt layerbox provides
13:29:50 - boud: same, probably, for the canvas which is in a scrolled pane, and that scrolls wit hthe arrow keys by default
13:31:44 - Bollebib: boud: is there a way to provide this functionality by just adding a seperate function ,similar to activate next/previous layer,but that works like the QT layerbox shortcut?
13:32:21 - Bollebib: and so that it does work when on canvas?
13:33:25 - boud: Bollebib: yes
Comment 1 Bollebib 2014-06-30 12:15:05 UTC
this could then get another name or description obviously
Comment 2 Halla Rempt 2015-02-14 11:13:38 UTC
Implemented by now.
Comment 3 Bollebib 2015-02-14 13:43:37 UTC
Reopened as something was not clear


Activate next/previous only activates in the same hierarchy-level

I need it to access ALL the levels (like how the QT arrow shortcuts in the layerbox work)
Comment 4 g6793396 2015-07-11 18:32:29 UTC
Created attachment 93566 [details]
enter groups with activateNextNode/activatePreviousNode

Since this is probably a shortcut used to speed workflow up, skipping the selection of the groups themselves could be desirable. I made a couple of tries at that but it is pretty hard to get right with the layers panel seemingly upside-down, it is easy one way with
while (node && node->childCount() && node->lastChild()){ node = node->lastChild(); }
but the other way need some recursive stuff.
Comment 5 Halla Rempt 2016-01-24 14:28:14 UTC
WISHGROUP: Small Usability Fixes

Ah, it doesn't actually enter groups yet, Dmitry says.
Comment 6 Bollebib 2016-11-06 11:11:42 UTC
right now ,this is actually solved.
But it does not go into hidden groups

i think even for hidden groups this should work,and go through EACH layer


might perhaps be necessary to close this bug and open a new one?
Comment 7 Dmitry Kazakov 2017-02-02 08:04:40 UTC
Hi, Bollebib!

Should this shortcut be able to enter *locked* groups as well?
Comment 8 Dmitry Kazakov 2017-02-06 13:43:41 UTC
Fixed in https://phabricator.kde.org/R37:6a909e99b81e