Bug 336660 - Scaling/sampling artifacts in radio button and checkbox hover decorations
Summary: Scaling/sampling artifacts in radio button and checkbox hover decorations
Status: REOPENED
Alias: None
Product: QtCurve
Classification: Frameworks and Libraries
Component: qt5 (other bugs)
Version First Reported In: git
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Yichao Yu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 14:20 UTC by Eike Hein
Modified: 2021-03-09 07:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Hovered radio button in QtCurve+Breeze (702 bytes, image/png)
2014-06-24 14:21 UTC, Eike Hein
Details
Hovered checkbox in QtCurve+Breeze (413 bytes, image/png)
2014-06-24 14:21 UTC, Eike Hein
Details
Current appearance (1.72 KB, image/png)
2014-07-27 20:31 UTC, Eike Hein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-06-24 14:20:32 UTC
Screenshots coming.

Reproducible: Always
Comment 1 Eike Hein 2014-06-24 14:21:31 UTC
Created attachment 87369 [details]
Hovered radio button in QtCurve+Breeze
Comment 2 Eike Hein 2014-06-24 14:21:52 UTC
Created attachment 87370 [details]
Hovered checkbox in QtCurve+Breeze
Comment 3 Andrew Lake 2014-06-28 16:02:03 UTC
For the moment this is a QtCurve issue. While not ideal, the radio button is remains appropriately discernible as a radio button and functions as it should. Not a critical issue. Will be addressed either by fixing the issue in QtCurve or when a C++ implementation of the reference UI controls design becomes available for QWidget-based applications.

Leaving open as needs info until the underlying QtCurve issue is identified.
Comment 4 Eike Hein 2014-06-28 16:37:30 UTC
I personally disagree that issues like this are "not critical". Rendition quality is an important aspect of graphical user interfaces that significantly affect the look and feel of software, and present a barrier-to-use in a very real way - many users will refuse to use or not enjoy using interfaces displaying sub-par rendering quality. This is especially true for users we're currently not yet reaching, and so also poses a barrier to expanding our userbase.

It's made more critical by the fact that the style engine carries enormous responsibility simply by dictating the appearance of so much software. The poor impression this and other bugs leave aren't a localized problem - they weigh heavy on the relationships of users with many different products made by KDE and others.

More pragmatically, it's also a regression over previous releases of the Plasma Workspace, since many dozens of similar problems have been solved in the Oxygen style engine - to the point of sometimes addressing single poorly-rendered pixels caused by overlapping drawcalls, or paying attention to sampling quality.

On the whole, I don't think QtCurve is currently up to the quality standards of a stable release - at least with the Breeze preset - and I think trying to ship it as a default is a mistake.
Comment 5 Andrew Lake 2014-06-28 17:44:20 UTC
All I can do is simply state what I did. From a visual design standpoint, for the reasons provided, I simply do not think this is critical. The issue identified here has no discernible effect on the user's ability to recognize or use the controls. There are many other regressions throughout Plasma 5, including real functional regressions, that go far beyond the pixel-level imperfections identified here. Whatever criteria we're using for determining that those regressions are either acceptable or not, I would argue should be consistent for these issues as well.

There exists no implementation using the Oxygen style engine that satisfies the target visual design for the UI controls. If an implementation becomes available that uses the Oxygen style engine to satisfy the target visual design then we'll review that then. The QtCurve with the Breeze theme was reviewed by both the VDG and the plasma team. The conclusion was that it sufficiently satisfies the visual design targets, and was acceptable to be shipped as default. The issue identified here does not, at least by my view, overwhelm the results of that review such that the decision should be reversed.
Comment 6 Eike Hein 2014-07-23 20:58:31 UTC
We're upstream now, reopening.
Comment 7 Eike Hein 2014-07-23 20:59:20 UTC
Resetting assignee.
Comment 8 Yichao Yu 2014-07-27 20:08:13 UTC
@Eike Hein

I've tried to implement your suggestions of scaling the images although I'm only using it as a way to do AA sliently differently.
Can you check if they looks better now?
Comment 9 Eike Hein 2014-07-27 20:31:28 UTC
Created attachment 87986 [details]
Current appearance

Still pretty bad here I'm afraid, doesn't look properly round at all ...
Comment 10 Yichao Yu 2014-07-27 20:38:48 UTC
And it also seems to affect combobox highlight somehow T_T... Need to work on it more....
Comment 11 Justin Zobel 2021-03-09 07:30:31 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.