Bug 336653 - kmail inverts HTML view settings
Summary: kmail inverts HTML view settings
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kmail2
Classification: Applications
Component: general (show other bugs)
Version: 4.13.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 11:33 UTC by Thomas Tanghus
Modified: 2018-01-31 16:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Tanghus 2014-06-24 11:33:51 UTC
I have KMail set to show HTML and load external references.
After upgrading to Kubuntu 14.04 it shortly shows the messages as HTML, but then reverts to plain text and the toggle button I had added doesn't work.
After changing the settings to *not* show as HTML and *not* load external references, it now does show HTML and loads external references :P



Reproducible: Always

Steps to Reproduce:
1. Set KMail to show as HTML and load external references.

Actual Results:  
It shows plain text

Expected Results:  
It should show as HTML

I'm on 4.13.2 but it is marked as 4.13.1 as that what the highest selectable version.
Comment 1 Thomas Tanghus 2014-06-24 11:35:10 UTC
Maybe I should mention that I have no folder specific settings for the above, and have never used any.
Comment 2 Thomas Tanghus 2014-06-24 12:14:29 UTC
OK, it seems I have found the reason:

I tried a while ago to have a separate addressbook for whitelisting specific email adresses to show as HTML and load external references.
As that was ignored in previous versions I disabled the addressbook and went back to just having it as default.
Now the contact specific settings is taken into account, instead of using that setting, it inverts the global setting!

This sounds like an honest mistake and an easy fix.

My guess is that it is coded like this (pseudo code)

renderHTML = globalRenderHTML;
if(contactSettingRenderHTML) {
    renderHTML = !globalRenderHTML;
}

Where instead it should be:

renderHTML = globalRenderHTML;
if(contactSettingRenderHTML) {
    renderHTML = contactSettingRenderHTML;
}

While fixing it please consider only rendering the content after any contact specific setting has been read, because as it is now it first shows the plain text version and then afterwards it renders the HTML version.
Also the addressbook in question was disabled. Shouldn't disabled addressbooks be ignored? Even though I would never have found the reason if they were ;)

But great that whitelisting email addresses this way works now :)
Comment 3 Laurent Montel 2014-06-24 13:45:51 UTC
Problem with email that you want to see in plain text when global settings is "show as html" was fixed in 4.14. We can't do it in 4.13.x because there is a lot changes and there is a new menu to specify if we want to force folder in plain text when global settings is "html" 

'Also the addressbook in question was disabled. Shouldn't disabled addressbooks be ignored?' it's not show in kaddressbook it's not disable in akonadi. So it's normal that it searchs in this addressbook too.
Comment 4 Thomas Tanghus 2014-06-24 14:05:01 UTC
(In reply to comment #3)
> Problem with email that you want to see in plain text when global settings
> is "show as html" was fixed in 4.14. We can't do it in 4.13.x because there
> is a lot changes and there is a new menu to specify if we want to force
> folder in plain text when global settings is "html" 

The problem wasn't that I wanted to see it as plain text, but rather the opposite. If the global setting is "show as HTML" and the contact setting is "Show messages received from this contact as: HTML" then it shows the email as plain text ;)
Comment 5 Laurent Montel 2014-06-24 14:58:35 UTC
Interesting indeed.
I will investigate it.
Comment 6 Sudhir Khanger 2014-09-29 17:05:02 UTC
I have been hit by this bug. I am using KMail Version 4.14.1 on Platform Version 4.14.1 on Fedora 20 Plasma 5.

Both prefer HTML and load external reference are enabled but everything is being loaded as plain text.
Comment 7 Sudhir Khanger 2014-09-29 17:09:31 UTC
Looks like not. Checking/unchecking and restarting Kontact a few times made it stick to global HTML. It's working for me. Sorry to bother.
Comment 8 Denis Kurz 2017-06-23 19:56:47 UTC
This bug has never been confirmed for a KDE PIM version that is based on KDE Frameworks (5.x). Those versions differ significantly from the old 4.x series. Therefore, I plan to close it in around two or three months. In the meantime, it is set to WAITINGFORINFO to give reporters the oportunity to check if it is still valid. As soon as someone confirms it for a recent version (at least 5.1, ideally even more recent), I'll gladly reopen it.

Please understand that we lack the manpower to triage bugs reported for versions almost two years beyond their end of life.
Comment 9 Denis Kurz 2018-01-31 16:53:24 UTC
Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.1 aka 15.12, preferably more recent), please open a new one unless it already exists. Thank you for all your input.