Bug 336462 - Tooltips don't adapt the size to the correct unit
Summary: Tooltips don't adapt the size to the correct unit
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Folder (show other bugs)
Version: master
Platform: unspecified Linux
: NOR minor
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-19 17:44 UTC by Aleix Pol
Modified: 2014-06-19 18:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleix Pol 2014-06-19 17:44:48 UTC
Something that are 6KiB, will show 6000 bytes.
Comment 1 Eike Hein 2014-06-19 17:51:10 UTC
This is a vague bug report - is the issue generally not using human-friendly units? That's because QML's Locale type has no formatter for it[1], the QML wrapper around KLocale's method[2] was removed in KF5 and it's not economical to do this leg work in Folder right now.

Hopefully QML's Locale stuff will improve in the future.

1 = http://doc-snapshot.qt-project.org/qt5-5.3/qml-qtqml-locale.html
2 = http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKLocale.html#a3116ebc59ad98cbf80dc06ff9489e330
Comment 2 Aleix Pol 2014-06-19 18:14:32 UTC
Yes, it's not human-friendly units. Actually the Folder View is only going to be used by humans, for the moment.

The fact that we can't fix it now doesn't mean this is not a problem.
Comment 3 Martin Klapetek 2014-06-19 18:22:08 UTC
I have a patch ready, waiting for Eike to approve.
Comment 4 Martin Klapetek 2014-06-19 18:39:02 UTC
Git commit e0aa5eaac8347b3c05977742fc8df31a957f46c0 by Martin Klapetek.
Committed on 19/06/2014 at 18:38.
Pushed by mklapetek into branch 'master'.

[folder] Format file sizes in tooltip using KFormat

Reviewed-by: Eike Hein

M  +2    -1    containments/folder/package/contents/ui/ItemDelegate.qml

http://commits.kde.org/plasma-desktop/e0aa5eaac8347b3c05977742fc8df31a957f46c0