Bug 336333 - Map view in import tool is very slow
Summary: Map view in import tool is very slow
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Import-Gphoto2 (show other bugs)
Version: 4.1.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 19:40 UTC by Michael G. Hansen
Modified: 2017-08-16 06:11 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.4.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael G. Hansen 2014-06-16 19:40:31 UTC
The map view in the import UI reacts very slowly, while the map view in the digikam main window appears to be quite fast, even with roughly the same amount of pictures (136 in my case).

Reproducible: Always
Comment 1 Veaceslav Munteanu 2014-07-05 20:09:05 UTC
Michael, I have a branch /development/usbimport in core, in which I tried to fix a freeze issue with usbimport. Can you check if code from that branch fixes(at least partially) this problem.
Comment 2 caulier.gilles 2014-08-31 22:42:35 UTC
Veaceslav,

What's new about your works on this file ?

Gilles Caulier
Comment 3 Veaceslav Munteanu 2014-09-01 08:10:37 UTC
I think I misunderstood what Michael tried to report... I was talking a bout different thing...
Comment 4 caulier.gilles 2014-09-01 08:28:19 UTC
Hi Veaceslav,

And what's about your work in your dedicated branch from git ?

Gilles
Comment 5 Veaceslav Munteanu 2014-09-01 16:41:28 UTC
Since Teemu operated a lot of changes on Import code, I can't no longer merge it with master. I don't know, for my set-up and camera SD card, import view is still freezing and I don't know what to do....
Comment 6 caulier.gilles 2014-09-25 13:34:43 UTC
Git commit 2298fd4e26825c7d4e59d83a28559a52676bd4a4 by Gilles Caulier.
Committed on 25/09/2014 at 13:31.
Pushed by cgilles into branch 'master'.

ImportUI MpaView : use Camera Thumbnails Contoller instead to use Camera Controller to get image thumbs from camera.
As Camera Thumbnails Controller use a cache mechanism to store pixmap, this will prevent to query camera device each time.
This will increase map view speed, especially with gphoto2 based cameras.
Note : cache is populated initially with icon-view.
FIXED-IN: 4.4.0

M  +2    -1    NEWS
M  +31   -22   app/views/mapwidgetview.cpp
M  +2    -1    app/views/mapwidgetview.h
M  +2    -2    utilities/importui/main/importui.cpp
M  +2    -1    utilities/importui/main/importui.h

http://commits.kde.org/digikam/2298fd4e26825c7d4e59d83a28559a52676bd4a4
Comment 7 Veaceslav Munteanu 2014-09-25 15:35:11 UTC
Gilles, I can confirm that your latest commit fix my problem with freezing import from usb :))

Thank you a lot, this was the most used part of digiKam and never had enough time to search the problem... )
Comment 8 caulier.gilles 2014-09-25 17:14:22 UTC
Hi veaceslav,

There are a lots of pending files to fix in bugzilla. I hope to have enough time to clean up more entries before Berlin meeting to have a clear vision of most important features to implement in the future.

At least, since 4.3.0, more than 200 files are closed, 100 are identified as duplicates, and 100 are in wait for info...

Gilles