Bug 336256 - bad plural forms in channel mode message
Summary: bad plural forms in channel mode message
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 293112
  Show dependency treegraph
 
Reported: 2014-06-15 10:40 UTC by Sebastien Renard
Modified: 2021-12-30 12:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.8.21121
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Renard 2014-06-15 10:40:41 UTC
When updating chan mode about user limit, the message is always in plural, even if the parameter is 1.
Ex.  You set the channel limit to 1 nicks (<= should be nick).

Looking at source code, the plural call is good : 
 if (fromMe) message = i18np("You set the channel limit to 1 nick.", "You set the channel limit to %1 nicks.", parameter);

But parameter is QString, so it always considered as "many". A simple change with a .toInt() remove the bug. 

Reproducible: Always

Steps to Reproduce:
1. Open a new chan to be operator
2. Open chan mode menu
3. Set user limit to 1 and look at message
Actual Results:  
 You set the channel limit to 1 nicks

Expected Results:  
 You set the channel limit to 1 nick
Comment 1 Philippe Cloutier 2014-06-15 18:10:46 UTC
I cannot reproduce this bug unless Konversation's interface is in a language other than French (only tested English) :
[15 juin 2014] [13:36:45] |Mode| Vous définissez la limite du canal à 1 pseudo.

However, I reported an opposite bug which happens when Konversation is in French in #293112.
Comment 2 Andrew Crouthamel 2018-11-12 02:50:01 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Andrew Crouthamel 2018-11-21 04:29:44 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Friedrich W. H. Kossebau 2021-12-30 12:10:23 UTC
Accidentally came across that misbehaviour recently and directly fixed it, not knowing about this bug report. A shame the fix was so simple and even already described in the bug report itself (toInt()), shows the eternal lack of resources... so just looking at the positive side, bug can be declared fixed.