Bug 336138 - Do not use localized date
Summary: Do not use localized date
Status: RESOLVED UNMAINTAINED
Alias: None
Product: trojita
Classification: Applications
Component: Core (other bugs)
Version First Reported In: git
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 18:09 UTC by Pali Rohár
Modified: 2024-09-23 18:49 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
The quoteText() function was modified to return a 'C' Locale LongFormat date (18.57 KB, text/x-c)
2015-04-12 19:44 UTC, Suhair Zain
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pali Rohár 2014-06-12 18:09:04 UTC
Trojita use localized date in compose window when replying to email e.g.

On nedeľa, 8. júna 2014 15:12:19 CEST, Jan Kundrát wrote:
>
>> On June 7, 2014, 9:24 p.m., Jan Kundrát wrote:
>  ...
>
> Random fun fact: the Czech versions of TB localize the header 
> names, but the date is formatted using the raw RFC5322 
> serialization ("Wed, 06 Jul ...").

It means that Trojita mixing english text "On .. wrote" with slovak date format "nedeľa, 8. júna 2014".

It looks ugly and foreign people does not have to understand localized date. Please change date format to neutral "C" locale.

Reproducible: Always
Comment 1 Jan Kundrát 2014-06-12 18:18:46 UTC
> It means that Trojita mixing english text "On .. wrote" with 
> slovak date format "nedeľa, 8. júna 2014".

Nope, it's using a localized date along with a translated string. The only 
problem is that the Slovak team did not contribute a translation yet.

> Please change date format to neutral "C" locale.

I recall you wanted to switch the whole stuff, both the text and the date 
format, to English. I'm not sure about that; it's not what most other MUAs 
do, IMHO. What do the others think?
Comment 2 Pali Rohár 2014-06-12 18:42:29 UTC
I do not like idea to reply with slovak (or other lang) localized header with english written text of email.
Comment 3 Thomas Lübking 2014-06-12 21:07:47 UTC
Matter of target audience.
My mom writes german mails to german ppl. from who she receives german mails, because it's the only language reasonably she speeks.

For this audience, a reply line like

  Am Donnerstag, den 12. Juni 2014, schrieben Sie

is really nice (though already this has glitches - my mom doesn't address her recipients by "Sie", but "Du")


I write mails in various languages (not gonna show off here - usually english, though ;-) to ppl. all across the planet - and that will likely hold for most IT affine ppl.
Of course I can interpret every "brumblefix sdew jlsda 12. asdhsk 2014 a sadwe" on top of the mail - despite having no idea about the actual meanin - but it's not useful nor "nice to have" but just junk i skip since I know it's basic meaning.

I would of course prefer a reminder in English, German or any other language i actually speak.

This is basically the same issue as with translating forwarded headers - you're translating for the wrong person.

For this reason, personally i'd perhaps go with sth. very technical and generic:

Jan Kundrát, 2014-06-12 18:18:46 UTC
----------------------------
> I recall you wanted to switch the whole stuff, both the text and the date 
> format, to English. I'm not sure about that; it's not what most other MUAs 
> do, IMHO. What do the others think?

where the date could be of any reasonable ISO/RFC format.
But this is oc. not as kind as

  Am Donnerstag, den 12. Juni 2014, schrieben Sie

==> matter of target audience.
In doubt make the line configurable (w/ a placeholder for the sender name) and start w/ the translated approach (assuming that this will fit the least capable user group)
Comment 4 Pali Rohár 2014-06-12 21:20:50 UTC
Configuration option (or maybe button/menu in compose window) can be usefull too. I really do not want to send emails with header "On nedeľa, 8. júna 2014 15:12:19 CEST, Jan Kundrát wrote:"

Btw, in KMail I can configure my own reply and forward template with also date format.
Comment 5 paalsteek 2014-06-13 08:11:33 UTC
On the one hand making those lines configurable allows everyone to change the behaviour to her own preferences. On the other hand I really like the fact that Trojitás configuration is clean and not overloaded with tons of options. That said I'd go with a translated version of the string for now. Althogh it doesn't really matter for me as my system is configured with LANG=en_US.UTF-8 anyway.
Comment 6 Jan Kundrát 2014-06-13 17:44:10 UTC
From my point of view, the default behavior of fully-localized reply header makes most sense as a default setting. I do not think that adding a fully-customizable templating engine would be of much use, so I would think twice before I e.g. accept a patch adding support for KMail's templates.

That said, an option about using English or localized variant of the language sounds like something useful. As a first step, having a combobox in the settings specifying the format of these replying/forwarding bits might be a useful thing. We can later play around and integrate this with a spell checker if we ever get one.

Patches welcome. I don't see myself working on it, though.
Comment 7 Suhair Zain 2015-04-12 19:44:01 UTC
Created attachment 91993 [details]
The quoteText() function was modified to return a 'C' Locale LongFormat date

This is my first time contribution to an existing repository/project. I hope you'll forgive me if this is not the recommended way to submit patches and that you'll guide me through the right process if I happen to be wrong.
Comment 8 Jan Kundrát 2015-04-12 20:52:05 UTC
Hi Suhair, the GSoC comment said "send a patch through Gerrit", so if you would like to work on this, be sure to follow these instructions. A simple search for "KDE Gerrit" should get you going.

Please also make sure that you read all comments on the bugreport before making patches. Does it really make sense to use a translated string and an English date format?
Comment 9 Christoph Cullmann 2024-09-23 18:49:06 UTC
Trojitá is no longer maintained, please switch to a maintained alternative like https://apps.kde.org/kmail2/

Sorry for the inconveniences.