Bug 335725 - Context menu doesn't disappear when assigning window to other activity than the current one
Summary: Context menu doesn't disappear when assigning window to other activity than t...
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: activities (show other bugs)
Version: git master
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 5
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-02 21:05 UTC by Elias Probst
Modified: 2021-12-06 04:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2014-06-02 21:05:30 UTC
Usually the context menu disappears when the window to which it belongs to isn't shown at the current position anymore (e.g. selecting another screen or desktop from the context menu).

When assigning another activity than the current one to a window via the context menu, the window disappears, but the context menu remains.

This behaviour should be consistent with the other cases.
Comment 1 Martin Flöser 2014-06-03 07:01:33 UTC
@Thomas: if I remember correctly this is intended, isn't it?
Comment 2 Elias Probst 2014-06-08 18:36:11 UTC
Another side-effect possibly caused by this:
after moving a window off the current activity and clicking the remaining context menu away, the next time the cursor is moved on to a windows title bar, the cursor type is "resize" (sometimes vertical, sometimes diagonal… couldn't find a pattern yet).

It needs a click on a window's titlebar, moving the cursor off it, then back onto it to get it back to normal.
Comment 3 Alexander Mentyu 2018-04-04 12:47:36 UTC
Can reproduce this bug.
When changing activity for an app - the right click menu isn't disappearing and there are also rendering/flickering issues when moving the app back and forth

Plasma: 5.12.3
Apps: 17.12.3
Frameworks: 5.44.0
Qt: 5.10.1
Kernel: 4.14.27-1-MANJARO
OS: Netrunner Rolling
Video: Intel 4400
xf86-video-intel 1:2.99.917+812+g75795523-1
Screen: 1600x900
Comment 4 David Edmundson 2018-10-10 12:54:15 UTC
It's clearly intentional, there's a whole code path to try and prevent updating activities whilst the menu is open. 

I think it's trying to prevent the main window changing too.

That code path is broken, we inhibit calling updateVisibility till the menu closes.

However Scene::Window::isVisible also checks. Possibly a later addition.

This means the main window hides, but not properly as we didn't call updateVisibility to repaint the damaged areas. Hence the flickering.


UserActions also doesn't unlock the blocker properly.
Comment 5 David Edmundson 2018-10-10 13:54:31 UTC
Git commit 273a3fabd0ee7aa1321c4636dc29e4c9b29fa5f1 by David Edmundson.
Committed on 10/10/2018 at 13:54.
Pushed by davidedmundson into branch 'Plasma/5.14'.

[activities] Fix logic error in user menu blocking activity updates

Summary:
There's an attempt to block updates to activities whilst the popup menu
is showing.

In one of the two code paths for positioning the menu the block is set
but instead of releasing the block at the end of the exec locks it
again.

Test Plan:
On X11 changed activities with the popup menu near the bottom.
It still flickered like crazy whilst the menu is open (see bug report)
But now at least fixes itself after

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16101

M  +1    -1    useractions.cpp

https://commits.kde.org/kwin/273a3fabd0ee7aa1321c4636dc29e4c9b29fa5f1
Comment 6 kde.org 2021-11-06 22:39:17 UTC
This issue report is quite old. AFAICT, David committed some changes for this. Can you please confirm, that it still persists with Plasma 5.23?
Comment 7 Bug Janitor Service 2021-11-21 04:38:52 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2021-12-06 04:38:15 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!