Bug 335675 - gwenview sometimes shows "0%" zoom when cycling through images after manually setting zoom
Summary: gwenview sometimes shows "0%" zoom when cycling through images after manually...
Status: RESOLVED DUPLICATE of bug 337262
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 4.13.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-02 01:36 UTC by Martin Walch
Modified: 2014-08-16 14:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of gwenview showing the problem (39.96 KB, image/png)
2014-06-02 01:36 UTC, Martin Walch
Details
Fix for bug 335675 (686 bytes, patch)
2014-07-09 07:39 UTC, John Zaitseff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Walch 2014-06-02 01:36:46 UTC
Created attachment 86959 [details]
screenshot of gwenview showing the problem

instead of the actual zoom level, gwenview sometimes just shows "0%" although the image is correctly shown

to reproduce:
1. run gwenview and open a folder with at least two images
2. open the first image by clicking on it
3. change zoom level to 200%
4. step to the next image
5. step back to return to the first image

after those steps gwenview has remembered to show the first image at 200% and displays it accordingly, but says that the zoom level is 0%
Comment 1 John Zaitseff 2014-07-09 07:38:59 UTC
The reason this happens is that q->zoomChanged() is not called from within DocumentViewPrivate::setCurrentAdapter().  I am attaching a fix for this bug (as run against the current Git tree).
Comment 2 John Zaitseff 2014-07-09 07:39:43 UTC
Created attachment 87656 [details]
Fix for bug 335675
Comment 3 Christoph Feck 2014-07-20 19:51:14 UTC
John, thanks for the investigation and patch! I suggest to create a review request at https://git.reviewboard.kde.org/

Please replace tabs with spaces before posting it there.
Comment 4 Christoph Feck 2014-08-16 14:32:21 UTC
John, any success with comment #3?
Comment 5 Christoph Feck 2014-08-16 14:36:42 UTC
Ignore my last comment, this is supposed to be fixed with your other patch.

*** This bug has been marked as a duplicate of bug 337262 ***