Bug 335122 - marking planned transaction is possible and fails
Summary: marking planned transaction is possible and fails
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.6.4
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 08:59 UTC by Wolfgang Rohdewald
Modified: 2014-09-23 20:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Rohdewald 2014-05-21 08:59:43 UTC
planned transactions should be ignored by the marking action

First problem: First select a normal transaction. Try to extend selection with a planned transaction. This is correctly not possible. But it is possible to first mark the planned transaction and then extend the selection with a normal transaction. This should not be possible either.

Second problem: Trying to mark both selected transactions as reconciled fails with
"Error". This error message should get more content.

Third problem: The full error message when clicking the Details button: 
Unable to modify transaction: Invalid transaction id 'SCH000024', thrown in /build/buildd/kmymoney-4.6.4/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp:820


Reproducible: Always

Steps to Reproduce:
1. select a normal transaction together with a planned transaction (greyed out).
2. mark them as whatever
3. bug dialog, see above
Comment 1 Cristian Oneț 2014-07-29 10:08:37 UTC
I can confirm this.
Comment 2 Cristian Oneț 2014-07-29 19:52:20 UTC
Git commit c89ebb9578222df5f84492a6a910d574b68a5839 by Cristian Oneț.
Committed on 29/07/2014 at 19:48.
Pushed by conet into branch 'master'.

Don't allow items of different types to be part of the same selection.

Check the typeids of the pointed to types instead of the pointer
types. This bad check was causing the correctly written code to fail.
With this fixed there is not way to change the reconlied state of a
scheduled transaction from the ledger thus the error will not appear
anymore.

M  +2    -2    kmymoney/widgets/register.cpp

http://commits.kde.org/kmymoney/c89ebb9578222df5f84492a6a910d574b68a5839
Comment 3 Cristian Oneț 2014-07-29 19:53:11 UTC
Git commit 6684b4796d0192f7241498f8f1e946e8f6870879 by Cristian Oneț.
Committed on 29/07/2014 at 19:48.
Pushed by conet into branch 'frameworks'.

Don't allow items of different types to be part of the same selection.

Check the typeids of the pointed to types instead of the pointer
types. This bad check was causing the correctly written code to fail.
With this fixed there is not way to change the reconlied state of a
scheduled transaction from the ledger thus the error will not appear
anymore.
(cherry picked from commit c89ebb9578222df5f84492a6a910d574b68a5839)

M  +2    -2    kmymoney/widgets/register.cpp

http://commits.kde.org/kmymoney/6684b4796d0192f7241498f8f1e946e8f6870879
Comment 4 Cristian Oneț 2014-09-23 20:30:03 UTC
Git commit 5277848b040237b81aac9d31a09299c523b33d82 by Cristian Oneț.
Committed on 23/09/2014 at 20:25.
Pushed by conet into branch 'master'.

Allow matching again by selecting imported and local transactions.

This has been broken by a previous fix for
Related: bug 339175

M  +3    -10   kmymoney/widgets/register.cpp

http://commits.kde.org/kmymoney/5277848b040237b81aac9d31a09299c523b33d82