Bug 335023 - Maximize effect: window.oldGeometry not updated on subsequent "quick maximizations"
Summary: Maximize effect: window.oldGeometry not updated on subsequent "quick maximiza...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-window-management (other bugs)
Version First Reported In: 4.11.8
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 4.11
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/118...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 05:58 UTC by enoopt.adams
Modified: 2014-06-04 14:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 4.11.10
Sentry Crash Report:
thomas.luebking: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description enoopt.adams 2014-05-19 05:58:47 UTC
If the desktop effect Maximise is enabled, if you drag a window to the top screen edge the window will resize, but the window title bar appears about an inch from the screen edge and moves up quickly. It appears as if the window is bounding off the screen edge.

Reproducible: Always




Also present in 4.13
Comment 1 Thomas Lübking 2014-05-19 09:15:22 UTC
- what window decoration?
- do you hide the titlebar for maximized windows?
- do you have the wobblywindows effect enabled?
Comment 2 enoopt.adams 2014-05-19 09:25:00 UTC
Oxygen
No
No
It's a bug present in my current arch install of kde 4.13 and I noticed that it is still present in the project neon iso.
Comment 3 Thomas Lübking 2014-05-19 14:23:33 UTC
happens only when dragging the window there for the second time - and intermideate *resize* should also get you back the "correct" behavior.
Comment 4 Thomas Lübking 2014-05-19 14:24:11 UTC
let's see whether we can fix this in 4.11 (should be script fixable anyway)
Comment 5 Thomas Lübking 2014-05-29 22:11:12 UTC
@enoopt.adams

Please see patch https://git.reviewboard.kde.org/r/118409/
It's a patch on javascript, so you can apply it locally (w/o having to recompile anything)
file to patch is /usr/share/apps/kwin/effects/kwin4_effect_maximize/contents/code/maximize.js
Comment 6 enoopt.adams 2014-05-30 04:24:24 UTC
Patch works perfectly, fixes the issue.
Comment 7 Thomas Lübking 2014-05-30 21:54:58 UTC
Git commit 3c8506992d3a05daa3f0752cc0f5e844acf2a8e2 by Thomas Lübking.
Committed on 29/05/2014 at 21:52.
Pushed by luebking into branch 'KDE/4.11'.

store geometry trail & use the correct oldGeometry

geometryChanged is always executed before maximizeChanged, so we
store the last changed geometry (through regular resize - the current
geometry) and the second last one (used exclusively so far) which is
the old geometry we want to use if the geometry change was caused
by the maximize change
FIXED-IN: 4.11.10
REVIEW: 118409

M  +6    -1    kwin/effects/maximize/package/contents/code/maximize.js

http://commits.kde.org/kde-workspace/3c8506992d3a05daa3f0752cc0f5e844acf2a8e2
Comment 8 Martin Flöser 2014-06-04 14:35:53 UTC
Git commit dec218a4441cb3233094ca8a486c4b7277081400 by Martin Gräßlin, on behalf of Thomas Lübking.
Committed on 29/05/2014 at 21:52.
Pushed by graesslin into branch 'master'.

store geometry trail & use the correct oldGeometry

geometryChanged is always executed before maximizeChanged, so we
store the last changed geometry (through regular resize - the current
geometry) and the second last one (used exclusively so far) which is
the old geometry we want to use if the geometry change was caused
by the maximize change

Forward port of 3c8506992d3a05daa3f0752cc0f5e844acf2a8e2 from kde-workspace

M  +6    -1    effects/maximize/package/contents/code/maximize.js

http://commits.kde.org/kwin/dec218a4441cb3233094ca8a486c4b7277081400