When starting a new game, two lines appear on stderr: Couldn't find node planet_name_background. Skipping rendering. Couldn't find node planet_ship_count_background. Skipping rendering. They are caused by map/mapitems.cc:124 QPixmap nameBackgroundPix = renderPixmap("planet_name_background", sectorSize, sectorSize); and map/mapitems.cc:136-137 QPixmap shipsBackgroundPix = renderPixmap("planet_ship_count_background", sectorSize, sectorSize); The reason is that pics/default_theme.svgz does not contain any elements with those names. What is the proper solution? Should there actually be background graphics for planet names and numbers or should those QPixmaps be removed?
Tracking this down leads to commit 3c8d7a28850d648efa3f4b6ebfd37b23c9062176 > Author: Dmitry Suzdalev <dimsuz@gmail.com> > Date: Sat Nov 14 10:18:57 2009 +0000 > > Added a support for two svg elements with IDs "planet_name_background" and "planet_ship_count_background" and made > them to be rendered under the respective texts in planet item. > > This is needed by our artists to do proper themeing. > > Review completed: http://reviewboard.kde.org/r/2086/ > (reviewed by Parker and Pierre) > > CCMAIL: eugene.trounev@gmail.com > > svn path=/trunk/KDE/kdegames/konquest/; revision=1049025 It looks like this has never been used. Should it be kept in the code?
In general unused code should be removed. But if it's a half-implemented feature, the feature could as well be implemented fully. That's a decision for the maintainer ... if there will be one again. You could put a patch on review board.
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!