Bug 334568 - Continuing a search in the search bar after using the search in the thumbnail bar is broken
Summary: Continuing a search in the search bar after using the search in the thumbnail...
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.19.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-09 22:37 UTC by Albert Astals Cid
Modified: 2014-05-10 08:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.13.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2014-05-09 22:37:36 UTC
What to do:
 * Open a file
 * Ctrl+f
 * Search something that is there many times like "a"
 * Go to the thumbnail bar
 * Search something that is not in the document like "adadafsdasdfas"
 * Continue the search of the search bar
 * See how it fails :/
Comment 1 Albert Astals Cid 2014-05-09 22:38:51 UTC
Broken in 2006 :/
Comment 2 Albert Astals Cid 2014-05-10 08:06:00 UTC
Git commit 6bf6b14f3c79ea15b86ab094cd85a689873a384c by Albert Astals Cid.
Committed on 10/05/2014 at 08:04.
Pushed by aacid into branch 'KDE/4.13'.

Do not reset the search if it's a different search id

Doesn't make any sense, why would we want a "running searches map" if we
always reset the previous one?
FIXED-IN: 4.13.2

M  +0    -5    core/document.cpp
M  +0    -2    core/document_p.h

http://commits.kde.org/okular/6bf6b14f3c79ea15b86ab094cd85a689873a384c
Comment 3 Albert Astals Cid 2014-05-10 08:07:28 UTC
Git commit 3c3d4373ab8c1fd5af23d320ac80eca4538c0151 by Albert Astals Cid.
Committed on 10/05/2014 at 08:04.
Pushed by aacid into branch 'master'.

Do not reset the search if it's a different search id

Doesn't make any sense, why would we want a "running searches map" if we
always reset the previous one?
FIXED-IN: 4.13.2

M  +0    -5    core/document.cpp
M  +0    -2    core/document_p.h

http://commits.kde.org/okular/3c3d4373ab8c1fd5af23d320ac80eca4538c0151