Bug 334508 - Pixel Snapping is broken for RectangleSelection Tool
Summary: Pixel Snapping is broken for RectangleSelection Tool
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-08 10:10 UTC by Paul Geraskin
Modified: 2014-05-10 09:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2014-05-08 10:10:14 UTC
Hi devs!

Pixel Snapping is broken for RectangleSelection Tool.  In Krita 2.7 pixel snapping was for the Rectangle selection. 
I guess it was broken when Dmitry added Vetor Selections possibly.

Could you revert pixel snapping for the Rectangle selection back? As it's difficult to select certain area now. We need the same snapping as CropTool has.

Explanation: http://i.imgur.com/PF2bRte.jpg

Thanks.
Comment 1 Dmitry Kazakov 2014-05-08 12:06:08 UTC
Git commit b0f4e6d7b3554021e33c36bc63d5cb7e149f081e by Dmitry Kazakov.
Committed on 08/05/2014 at 12:05.
Pushed by dkazakov into branch 'master'.

Fix pixel-alignment of the Rectangle and Ellipse tools

Now there are a bit complex rules of rounding, but they do exactly
what the user expects from the tool.

M  +5    -1    krita/ui/tool/kis_tool_ellipse_base.cpp
M  +1    -1    krita/ui/tool/kis_tool_ellipse_base.h
M  +33   -3    krita/ui/tool/kis_tool_rectangle_base.cpp
M  +2    -3    krita/ui/tool/kis_tool_rectangle_base.h

http://commits.kde.org/calligra/b0f4e6d7b3554021e33c36bc63d5cb7e149f081e
Comment 2 Halla Rempt 2014-05-10 09:10:23 UTC
Git commit df2d70e4f32531b470b578c5d3d6fcba14819299 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 08/05/2014 at 12:05.
Pushed by rempt into branch 'calligra/2.8'.

Fix pixel-alignment of the Rectangle and Ellipse tools

Now there are a bit complex rules of rounding, but they do exactly
what the user expects from the tool.

M  +5    -1    krita/ui/tool/kis_tool_ellipse_base.cpp
M  +1    -1    krita/ui/tool/kis_tool_ellipse_base.h
M  +33   -3    krita/ui/tool/kis_tool_rectangle_base.cpp
M  +2    -3    krita/ui/tool/kis_tool_rectangle_base.h

http://commits.kde.org/calligra/df2d70e4f32531b470b578c5d3d6fcba14819299