Brush outline shortcuts two of the segments of the otline with a single segment. So a single pixel brush has the outline of a triangle, etc. Also, when not in OpenGL mode, it seems that the common point of two adjacent segments is invisible, probably due to double negation. It gives poor visibility if the canvas zoom is not high. Reproducible: Always Steps to Reproduce: 1. Choose a brush with a known, simple shape. 2. If not in OpenGL mode, the outline behaves strangely and has visibility problems. 2. Zoom--in the canvas, until pixels are visible as clear rectangles. 3. See the shortcutted segments. Expected Results: Outline having the exact shape of the brush, and no double color negation.
Yes, I can confirm the little triangle effect.
I have fixed the bug today locally, now I just need a bit of cleanup.
Git commit d77d384df606af304103ff84de9a26bb9c81472e by Dmitry Kazakov. Committed on 08/05/2014 at 09:53. Pushed by dkazakov into branch 'master'. Fix a triangular brush outline for a 1px brush This patch also fixes major code duplications in the KisOutlineGenerator. Now everything is templated. M +108 -155 krita/image/kis_outline_generator.cpp M +15 -5 krita/image/kis_outline_generator.h http://commits.kde.org/calligra/d77d384df606af304103ff84de9a26bb9c81472e
Git commit 31a82094e2413188c75c00983424459787ab1ed5 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 08/05/2014 at 09:53. Pushed by rempt into branch 'calligra/2.8'. Fix a triangular brush outline for a 1px brush This patch also fixes major code duplications in the KisOutlineGenerator. Now everything is templated. M +108 -155 krita/image/kis_outline_generator.cpp M +15 -5 krita/image/kis_outline_generator.h http://commits.kde.org/calligra/31a82094e2413188c75c00983424459787ab1ed5