Bug 334301 - Forgets modified state if you go to Advanced tab
Summary: Forgets modified state if you go to Advanced tab
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_icons (show other bugs)
Version: 4.11.8
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-03 21:57 UTC by Grósz Dániel
Modified: 2018-04-27 14:32 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-desktop/9496728fcb6c012cf1deb773a3d0a5129b4a629e
Version Fixed In: 5.13.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Grósz Dániel 2014-05-03 21:57:13 UTC 
Yada yada. See steps to reproduce.

Reproducible: Always

Steps to Reproduce:
1. Select different icon theme. (-> Apply button becomes enabled.)
2. Go to Advanced tab. (Don't change anything there.)
Actual Results:  
Apply button becomes disabled again. You can quit Systemsettings without a question, and the icons don't change.

Expected Results:  
Apply button remains enabled.
Comment 1 Kai Uwe Broulik 2018-04-27 14:32:09 UTC 
Git commit 9496728fcb6c012cf1deb773a3d0a5129b4a629e by Kai Uwe Broulik.
Committed on 27/04/2018 at 14:28.
Pushed by broulik into branch 'master'.

[Icon KCM] Port to new design

This completely drops the icon customization with icon effects and only retains the icon size settings.
Should there be any custom icon effects, pressing "Defaults" in the KCM will remove them.
I also couldn't find any trace of that "animations enabled" check box it used to have.
It adds drag and drop support for installing archives as themes. It can also download them from remote location
when dropped from e.g. a browser.

Installing theme files actually never worked in Plasma 5 as it got broken in the port from KIO NetAccess
to storedGet.
An animated preview is also added on hover showing a common selection of icons.

Implements T7262
Related: bug 367619, bug 163992
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D12459

M  +8    -14   kcms/icons/CMakeLists.txt
M  +1    -1    kcms/icons/Messages.sh
D  +0    -716  kcms/icons/icons.cpp
D  +0    -147  kcms/icons/icons.h
A  +205  -0    kcms/icons/iconsmodel.cpp     [License: GPL (v2+)]
A  +84   -0    kcms/icons/iconsmodel.h     [License: GPL (v2+)]
D  +0    -491  kcms/icons/iconthemes.cpp
D  +0    -74   kcms/icons/iconthemes.h
R  +0    -0    kcms/icons/kcm_icons.desktop [from: kcms/icons/icons.desktop - 100% similarity]
M  +493  -48   kcms/icons/main.cpp
M  +75   -18   kcms/icons/main.h
A  +169  -0    kcms/icons/package/contents/ui/IconSizePopup.qml     [License: GPL (v2/3)]
A  +276  -0    kcms/icons/package/contents/ui/main.qml     [License: GPL (v2/3)]
A  +16   -0    kcms/icons/package/metadata.desktop
D  +0    -16   kcms/icons/tests/CMakeLists.txt
D  +0    -16   kcms/icons/tests/testicons.cpp

https://commits.kde.org/plasma-desktop/9496728fcb6c012cf1deb773a3d0a5129b4a629e