Bug 334274 - Add an option to only index filenames
Summary: Add an option to only index filenames
Status: RESOLVED FIXED
Alias: None
Product: Baloo
Classification: Unmaintained
Component: Baloo File Daemon (other bugs)
Version First Reported In: 4.13
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Vishesh Handa
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-05-03 11:45 UTC by Shimi Chen
Modified: 2017-11-18 18:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shimi Chen 2014-05-03 11:45:11 UTC
A lot of my documents have names that are unique as a filename but appear as strings inside many other documents. This makes finding them actually harder, which is why I switched a long time ago from desktop search to fsrunner (https://code.google.com/p/fsrunner/) which seems to sadly no longer be developed. In addition, if there is no added functionality (for me personally) in full-text indexing, it is just wasting cpu and i/o (regardless of how efficient it gets). I just never find myself looking for where i wrote some string, and often want to quickly (in krunner) pull a file I know the name of. Not trying to harsh on the technology, just seems that the use case it was designed for is slightly different than mine, and it would be great if I could use a standard KDE technology rather than a third party add-on for the same function.
Adding a config option seems to be pretty trivial according to this g+ thread:
https://plus.google.com/u/0/+JosPoortvliet/posts/VjWHdC1H6AD?cfem=1

Reproducible: Always

Steps to Reproduce:
1. Open System Settings
2. Click on Desktop Search
3. Look for an option to disable full-text indexing while still indexing filenames
Actual Results:  
No such option exists

Expected Results:  
Having an option to toggle that
Comment 1 Vishesh Handa 2014-05-12 14:39:01 UTC
For anyone interested in solving this bug, you need to edit the basicindexingjob.cpp in baloo, and always set the indexing level to 2, if a certain option is enabled in a config file.

Marking this a junior job.
Comment 2 Pinak Ahuja 2014-08-14 16:25:39 UTC
Review request added
https://git.reviewboard.kde.org/r/119789/
Comment 3 Vishesh Handa 2014-08-25 11:17:53 UTC
Git commit 90c0f9829c80b361dbd7c8ecc3c3e169b49f3664 by Vishesh Handa, on behalf of Pinak Ahuja.
Committed on 25/08/2014 at 11:28.
Pushed by vhanda into branch 'master'.

File: Add an "only basic indexing" option

This allows the few users who do not want to index the contents of the
file to configure Baloo to not do that. It's a hidden option you need to
manually add in the general section of the baloofilerc file.
REVIEW: 119789

M  +7    -1    src/file/basicindexingjob.cpp
M  +3    -1    src/file/basicindexingjob.h
M  +1    -1    src/file/basicindexingqueue.cpp
M  +1    -1    src/file/extractor/app.cpp
M  +6    -0    src/file/fileindexerconfig.cpp
M  +3    -0    src/file/fileindexerconfig.h

http://commits.kde.org/baloo/90c0f9829c80b361dbd7c8ecc3c3e169b49f3664
Comment 4 Simone Gaiarin 2017-11-18 18:15:43 UTC
Hidden options are bad!

For who is wondering, in order to activate this add the following line to ./.config/baloorc

[General]
only basic indexing=true


To the developers: this option should be added commented out in the default baloorc installed on the system, to make the life easier to those who want to use it.

Moreover, for me, a checkbox to enable it should also be added to the UI configuartion dialog.
Comment 5 Simone Gaiarin 2017-11-18 18:16:45 UTC
Oh well. Apparently the check box is there! Sorry for the fuss.