Bug 334177 - The desktop file for the kwinscripts module in the system settings holds a wrong Exec-command.
Summary: The desktop file for the kwinscripts module in the system settings holds a wr...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: scripting (other bugs)
Version First Reported In: unspecified
Platform: Arch Linux All
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-01 12:20 UTC by jhnnslschnr
Modified: 2014-10-29 10:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.1.1
Sentry Crash Report:


Attachments
Patch for kwin 5. (299 bytes, patch)
2014-10-29 09:08 UTC, jhnnslschnr
Details
Patch for kwin 5 (717 bytes, patch)
2014-10-29 09:54 UTC, jhnnslschnr
Details
Patch for kwin 5 (725 bytes, patch)
2014-10-29 10:27 UTC, jhnnslschnr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jhnnslschnr 2014-05-01 12:20:20 UTC
Currently kwinscripts.desktop contains the line "Exec=kcmshell4 kwin-scripts" which should be replaced by "Exec=kcmshell4 kwinscripts".


Reproducible: Always

Steps to Reproduce:
1. Try to launch the kwinscripts module e.g. via krunner
Actual Results:  
Nothing happens (some terminal error output is actually produced).

Expected Results:  
kwinscripts module window should open.

This bug has been ported from kde4 to kde5:
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/4d301f5a2e275301c6c0dfb1aca44be2b3ce1c41
Comment 1 jhnnslschnr 2014-10-29 09:08:30 UTC
Created attachment 89355 [details]
Patch for kwin 5.
Comment 2 Martin Flöser 2014-10-29 09:21:24 UTC
thanks for the patch. In case you have a git clone you could provide it as a git format-patch'ed diff which would keep your ownership. If not I'll integrate this patch.
Comment 3 jhnnslschnr 2014-10-29 09:54:05 UTC
Created attachment 89356 [details]
Patch for kwin 5
Comment 4 Martin Flöser 2014-10-29 10:04:55 UTC
Our commit hook denied the commit:
remote: Audit failure - Commit 11eec3ff7eb74b7e03f52371a9883422813d4359 - Non-full name: jleuschner
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit
remote: error: hook declined to update refs/heads/Plasma/5.1
To ssh://git@git.kde.org/kwin
 ! [remote rejected] Plasma/5.1 -> Plasma/5.1 (hook declined)
error: failed to push some refs to 'ssh://git@git.kde.org/kwin'

--
If you don't mind having your real name exposed in the git log, please tell me (feel free to do so by private mail to mgraesslin [at] kde [dot] org)
Comment 5 jhnnslschnr 2014-10-29 10:27:50 UTC
Created attachment 89357 [details]
Patch for kwin 5

Sorry, that was my kde identity username, i'm just learning how to contribute. Here is the patch with my full name.
Comment 6 Martin Flöser 2014-10-29 10:46:16 UTC
Git commit 9e5f7009b35ddf90db4bb7689835e0dc4d563486 by Martin Gräßlin, on behalf of Johannes Leuschner.
Committed on 29/10/2014 at 09:50.
Pushed by graesslin into branch 'Plasma/5.1'.

Correcting Exec command in kwinscripts.desktop
FIXED-IN: 5.1.1

M  +1    -1    kcmkwin/kwinscripts/kwinscripts.desktop

http://commits.kde.org/kwin/9e5f7009b35ddf90db4bb7689835e0dc4d563486
Comment 7 Martin Flöser 2014-10-29 10:47:32 UTC
> Sorry, that was my kde identity username, i'm just learning how to contribute. 

no problem at all. I also didn't know otherwise I would not have tried to push :-P

Thanks for the patch!