Bug 333624 - "Lookup missing altitude values" in the geolocation dialog is broken [patch]
Summary: "Lookup missing altitude values" in the geolocation dialog is broken [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Geolocation-ReverseGeoCoding (show other bugs)
Version: 4.5.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-19 15:30 UTC by Tobias Leupold
Modified: 2017-08-19 06:10 UTC (History)
9 users (show)

See Also:
Latest Commit: http://commits.kde.org/digikam/2aa67aa37069868b953335ceaba5e77ce33d4ff2
Version Fixed In: 5.0.0

Attachments
patch for libkgeomap to add mapquest based altitude lookup (13.33 KB, patch)
2014-12-21 15:20 UTC, justus 		Details
ask factory for mapquest based lookup (611 bytes, patch)
2014-12-21 15:22 UTC, justus 		Details
patch for libkgeomap to add mapquest based altitude lookup (13.33 KB, patch)
2014-12-21 15:32 UTC, justus 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2014-04-19 15:30:31 UTC 
When using the geolocation dialog, the "Lookup missing altitude values" function does nothing. All values remain as they are.

Reproducible: Always
Comment 1 Johannes Zarl-Zierl 2014-04-22 21:45:10 UTC 
Reassigning to kipiplugins-gpssync.
Comment 2 Tobias Leupold 2014-08-03 17:59:37 UTC 
*** Bug 338007 has been marked as a duplicate of this bug. ***
Comment 3 justus 2014-12-21 15:17:42 UTC 
i had the same problem and modified the altitude lookup to use the mapquest service: http://open.mapquestapi.com/elevation/

i don't know if it would be legal to use this in libkgeomap. i'll attach my sources anyway (without the mapquest key, one can request one for free on the website). maybe one could request a key for the kde project and check it in. 

the code is a 1:1 copy of the geonames lookup code with tiny modifications.
Comment 4 justus 2014-12-21 15:20:39 UTC 
Created attachment 90075 [details]
patch for libkgeomap to add mapquest based altitude lookup
Comment 5 justus 2014-12-21 15:22:11 UTC 
Created attachment 90076 [details]
ask factory for mapquest based lookup
Comment 6 justus 2014-12-21 15:32:47 UTC 
Created attachment 90077 [details]
patch for libkgeomap to add mapquest based altitude lookup
Comment 7 caulier.gilles 2015-03-01 13:01:19 UTC 
*** Bug 342426 has been marked as a duplicate of this bug. ***
Comment 8 caulier.gilles 2015-05-12 13:45:48 UTC 
Maik,

Here a patch is provided with mostly new source code files, which must be easy to integrate in git/master. Not tested however...

Gilles
Comment 9 Maik Qualmann 2016-03-07 20:06:41 UTC 
Currently work geonames.org with altitude look up in digiKam-5.0.0. I also see the credits / transactions in a free account from geonames.org in advantage.

Maik
Comment 10 Maik Qualmann 2016-04-17 07:41:57 UTC 
Git commit 2aa67aa37069868b953335ceaba5e77ce33d4ff2 by Maik Qualmann.
Committed on 17/04/2016 at 07:40.
Pushed by mqualmann into branch 'master'.

remove last KIO dependency from geolocation editor
Related: bug 354687
FIXED-IN: 5.0.0

M  +3    -2    NEWS
M  +0    -1    utilities/geolocation/editor/CMakeLists.txt
M  +2    -3    utilities/geolocation/editor/backends/backend-geonames-rg.cpp
M  +36   -46   utilities/geolocation/editor/backends/backend-geonamesUS-rg.cpp
M  +4    -11   utilities/geolocation/editor/backends/backend-geonamesUS-rg.h
M  +2    -2    utilities/geolocation/editor/backends/backend-osm-rg.cpp
M  +2    -2    utilities/geolocation/editor/reversegeocoding/parsetagstring.h
M  +1    -1    utilities/geolocation/geoiface/CMakeLists.txt

http://commits.kde.org/digikam/2aa67aa37069868b953335ceaba5e77ce33d4ff2