Bug 333387 - Tags manager: Unavailable actions should be disabled when root item is selected
Summary: Tags manager: Unavailable actions should be disabled when root item is selected
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Manager (show other bugs)
Version: 4.0.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-13 19:30 UTC by Michael G. Hansen
Modified: 2017-07-29 07:53 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/digikam/5fc74bb58526b65adc297015398e5f1dcc5ebbd5
Version Fixed In: 4.1.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Michael G. Hansen 2014-04-13 19:30:18 UTC 
When the root item is selected in the tags manager, the "-" action and the "Reset tag icon" actions should IMHO be disabled in the UI. When clicking on the "-" action, nothing happens, while the "Reset tag icon" action opens an explaining message box.

Digikam version: git master

Reproducible: Always
Comment 1 Michael G. Hansen 2014-04-13 19:36:24 UTC 
The action "Add to list" should also be disabled when no tag is selected.
Comment 2 Michael G. Hansen 2014-04-13 19:40:21 UTC 
When selecting "All tags" in the quick access list, the context menu action "Delete selected from list" is also still available however does nothing.
Comment 3 Veaceslav Munteanu 2014-05-14 11:01:48 UTC 
Confirmed. Will fix them soon.
Comment 4 Veaceslav Munteanu 2014-06-01 17:27:23 UTC 
Git commit 611e523a95616f82ec1cd818a18afefb4ccce82e by Veaceslav Munteanu.
Committed on 01/06/2014 at 20:26.
Pushed by munteanu into branch 'master'.
Related: bug 1

M  +27   -3    digikam/tags/tagsmanager/tagsmanager.cpp
M  +5    -0    digikam/tags/tagsmanager/tagsmanager.h

http://commits.kde.org/digikam/611e523a95616f82ec1cd818a18afefb4ccce82e
Comment 5 Veaceslav Munteanu 2014-06-01 18:08:17 UTC 
Git commit dd0a20c8fec10887d0a9ab6634774dfa51c924bb by Veaceslav Munteanu.
Committed on 01/06/2014 at 21:07.
Pushed by munteanu into branch 'master'.
Related: bug 2

M  +4    -0    digikam/tags/tagsmanager/models/tagmngrlistview.cpp
M  +5    -0    digikam/tags/tagsmanager/taglist.cpp
M  +6    -0    digikam/tags/tagsmanager/taglist.h
M  +5    -3    digikam/tags/tagsmanager/tagsmanager.cpp

http://commits.kde.org/digikam/dd0a20c8fec10887d0a9ab6634774dfa51c924bb
Comment 6 Veaceslav Munteanu 2014-06-01 18:30:33 UTC 
Git commit 879544275294331fe46b5f526dce2afeb35cbbd9 by Veaceslav Munteanu.
Committed on 01/06/2014 at 21:27.
Pushed by munteanu into branch 'master'.

M  +12   -2    digikam/tags/tagsmanager/tagpropwidget.cpp

http://commits.kde.org/digikam/879544275294331fe46b5f526dce2afeb35cbbd9
Comment 7 Veaceslav Munteanu 2014-06-01 19:18:04 UTC 
Git commit 5fc74bb58526b65adc297015398e5f1dcc5ebbd5 by Veaceslav Munteanu.
Committed on 01/06/2014 at 22:17.
Pushed by munteanu into branch 'master'.

M  +22   -1    digikam/tags/tagsmanager/tagmngrtreeview.cpp

http://commits.kde.org/digikam/5fc74bb58526b65adc297015398e5f1dcc5ebbd5
Comment 8 Veaceslav Munteanu 2014-06-01 19:19:03 UTC 
I'm done with fixing, if you find anything else, please reopen :)
Comment 9 Michael G. Hansen 2014-06-02 20:32:20 UTC 
Hi Veaceslav,

the disabling/enabling seems to work fine. The only one that could still be disabled is "Expand selected nodes" if the nodes do not have subitems.

Best regards,

Michael