Bug 333314 - git commit ignores unselected files
Summary: git commit ignores unselected files
Status: CONFIRMED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: git master
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs, regression
: 358256 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-11 10:58 UTC by peje66
Modified: 2018-09-26 05:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description peje66 2014-04-11 10:58:46 UTC
I want to commit changes of several, but not all, changed files in a project.

I select Git->commit from Projects
I unselect files that I don't want to commit
enter commit message and commits

Now all changed files are commited, even those who I unselected.



Reproducible: Always

Actual Results:  
All changed files are commited

Expected Results:  
Only files who are checked in the "Changes"-window should be commited.
Comment 1 Kevin Funk 2014-04-14 16:59:11 UTC
Regression caused by 0212ca9034e54f9d6be8fd92a8b0f1a9021982b2.
Comment 2 Kevin Funk 2014-04-14 17:52:21 UTC
@Reporter: Note, you can fix this issue by removing the "Patch Review" tool view in the "Code" area.

I still think we should make sure to avoid this issue in the first place (regardless of multiple "Patch Review" tool views open) hence leaving this open.
Comment 3 Aleix Pol 2014-04-15 00:12:44 UTC
If that's the case, then the correct fix would be to make it possible to have some ToolViews on specific areas.
Comment 4 peje66 2014-04-15 05:53:17 UTC
On 2014-04-15 02:12, Aleix Pol wrote:
> https://bugs.kde.org/show_bug.cgi?id=333314
>
> --- Comment #3 from Aleix Pol <aleixpol@kde.org> ---
> If that's the case, then the correct fix would be to make it possible to have
> some ToolViews on specific areas.
>
I disabled "Patch Review" from the "Code area" and verified that git
only commits selected files.
Comment 5 peje66 2018-09-26 05:48:25 UTC
*** Bug 358256 has been marked as a duplicate of this bug. ***