Bug 333256 - Pawn Promotion Incorrect In Xboard Protocol
Summary: Pawn Promotion Incorrect In Xboard Protocol
Status: RESOLVED FIXED
Alias: None
Product: knights
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Other
: NOR normal
Target Milestone: ---
Assignee: Miha Čančula
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-10 00:55 UTC by Dave Kaye
Modified: 2016-03-13 10:22 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/knights/2f92ba88ac66baeaf1865b989dde03b556144cae
Version Fixed In:
Sentry Crash Report:

Attachments
Patch for bug 333256 (540 bytes, patch)
2014-04-12 17:37 UTC, Dave Kaye 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Kaye 2014-04-10 00:55:20 UTC 
The string sent to a chess engine using Xboard protocol is for example e7e8=Q    This will work with a number of chess engines.  However the Xboard specification is e7e8q   This will work with more chess engines.

Reproducible: Always
Comment 1 Dave Kaye 2014-04-12 17:37:49 UTC 
Created attachment 86060 [details]
Patch for bug 333256

This code should work on both the 2.5 and 2.4 versions of Knights.

It will cause the pawn promotion to be sent as e7e8q.  It was developed from the uci code.
Comment 2 Alexander Semke 2016-03-13 10:22:47 UTC 
Git commit 2f92ba88ac66baeaf1865b989dde03b556144cae by Alexander Semke.
Committed on 13/03/2016 at 10:21.
Pushed by asemke into branch 'master'.

Fixed incorrect pawn promotion in the Xboard protocol

Code cleanup in XBoardProtocol.

M  +244  -317  src/proto/xboardprotocol.cpp
M  +59   -55   src/proto/xboardprotocol.h

http://commits.kde.org/knights/2f92ba88ac66baeaf1865b989dde03b556144cae