Bug 333012 - Trackmouse effect does not account paintdata scale/translation
Summary: Trackmouse effect does not account paintdata scale/translation
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: 4.11.7
Platform: openSUSE Linux
: NOR normal
Target Milestone: 4.11
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/118...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-03 10:53 UTC by Rafael Linux User
Modified: 2014-07-12 18:10 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/kde-workspace/e9919695e57612055acfc685707210c00a42ce00
Version Fixed In: 4.11.11
Sentry Crash Report:
thomas.luebking: ReviewRequest+

Attachments
A still captured from the effect combination (zoom + track mouse) (27.97 KB, image/jpeg)
2014-06-04 13:40 UTC, Rafael Linux User 		Details
This is the correct way of seeing "track mouse" (without "Zoom" effect) (30.57 KB, image/jpeg)
2014-06-04 13:44 UTC, Rafael Linux User 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Linux User 2014-04-03 10:53:43 UTC 
I detected a bug in KDE 4.11.5 (OpenSUSE 13.1 x64) desktop effects.
"Track mouse"  effect combined with "Zoom" effect, under certain escenario, do strange things.

Reproducible: Always

Steps to Reproduce:
1. Enable "Zoom" and "Track mouse" effects. 
2. Configure the "Zoom" effect and select "Disabled" in "Follow (or track) the mouse" combo box.
3. "Accept"
4. Apply a zoom to the screen (using shortcut to "zoom" the scrreen) and activate "Track mouse" effect shortcut.
5. Move mouse pointer while "Track mouse" effect is on. 
Actual Results:  
As you can Mouse pointer is located separated of the "arcs" and they are spinning around some other center.


Expected Results:  
"Arcs" of animated "Track mouse" following the mouse pointer and sharing the same center.

Mouse and "track mouse" animation are not sharing the same point center, and the "arcs" of the animation neither.
Comment 1 Rafael Linux User 2014-06-04 13:40:57 UTC 
Created attachment 87006 [details]
A still captured from the effect combination (zoom + track mouse)

The two arcs are moving respect different centers (we are in zoom mode, remember that)
Comment 2 Rafael Linux User 2014-06-04 13:44:21 UTC 
Created attachment 87007 [details]
This is the correct way of seeing "track mouse" (without "Zoom" effect)
Comment 3 Thomas Lübking 2014-06-04 18:53:42 UTC 
Thanks for the reminder (seriously - i wanted to fix it, but it simply dropped off the table)
Comment 4 Rafael 2014-06-04 22:47:53 UTC 
No problem. I wish you can fix it.

;)
Comment 5 Thomas Lübking 2014-06-05 06:47:23 UTC 
Have, see URL field for review request of the patch.
Comment 6 Rafael Linux User 2014-06-05 07:39:27 UTC 
Viewed. So I must say your description of the issue is more clear than mine   ; )
Comment 7 Thomas Lübking 2014-07-09 16:04:42 UTC 
Git commit e9919695e57612055acfc685707210c00a42ce00 by Thomas Lübking.
Committed on 05/06/2014 at 18:16.
Pushed by luebking into branch 'KDE/4.11'.

make trackmouse FX account paintdata scale/trans

REVIEW: 118537
FIXED-IN: 4.11.12

M  +7    -3    kwin/effects/trackmouse/trackmouse.cpp

http://commits.kde.org/kde-workspace/e9919695e57612055acfc685707210c00a42ce00
Comment 8 Martin Flöser 2014-07-10 11:42:44 UTC 
Git commit 5185fe81cf8a5163ca83d156b9ff34656cc8da58 by Martin Gräßlin.
Committed on 10/07/2014 at 11:35.
Pushed by graesslin into branch 'master'.

make trackmouse FX account paintdata scale/trans

REVIEW: 118537

cherry-picked from kde-workspace
e9919695e57612055acfc685707210c00a42ce00.

Original author: luebking

M  +7    -3    effects/trackmouse/trackmouse.cpp

http://commits.kde.org/kwin/5185fe81cf8a5163ca83d156b9ff34656cc8da58