Bug 332990 - Cancelling the opening of a file collapses document treeview
Summary: Cancelling the opening of a file collapses document treeview
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (other bugs)
Version First Reported In: 3.12.97
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 23:42 UTC by Albert Astals Cid
Modified: 2014-06-30 18:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 4.13.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2014-04-02 23:42:17 UTC
How to reproduce:
 * Open file a from a folder aa
 * Open file b from a folder bb
 * Now your document tree looks like
   aa
    \-> a
   bb
    \-> b
 * Now While your current document is b, press Ctrl+O and then ESC
 * See how the aa folder of the document tree has collapsed without any particular reason for it
Comment 1 Albert Astals Cid 2014-05-25 09:58:13 UTC
Initial patch at https://git.reviewboard.kde.org/r/118312/ would appreciate testing/review.
Comment 2 rgpublic 2014-06-03 10:27:57 UTC
For the record: It not only collapses when cancelling. It also collapses when opening another file. I'd like to nominate this bug as IMHO *worst* ever Kate bug. This is so annoying I can hardly find words for this. If you have lots of different folders several levels deep opened and you have to uncollapse them every time you open anything this makes Kate really almost *unusable* for me and I'm not using that word light-heartedly. Hope the patch from Albert appears soon in mainline Ubuntu. Think I'll really need to find another editor for the time being :-/
Comment 3 Albert Astals Cid 2014-06-30 18:17:04 UTC
Git commit 40fca6252ff6a2fd041dff46eebb460784fd1637 by Albert Astals Cid.
Committed on 30/06/2014 at 18:15.
Pushed by aacid into branch 'KDE/4.13'.

Do not reset the model without need

>From reading the code i see no need to reset the model, the only think that i see the reset do is cause the view to "reset" too and the state of open/closed roots in the tree gets broken.

Used it for a few minutes and everything worked fine. Reading the code don't see why it shouldn't. I'll it use it a bit more for a few more days.
FIXED-IN: 4.13.3
REVIEW: 118312

M  +0    -4    kate/filetree/katefiletreemodel.cpp

http://commits.kde.org/kate/40fca6252ff6a2fd041dff46eebb460784fd1637
Comment 4 Albert Astals Cid 2014-06-30 18:18:46 UTC
Git commit 5f24757090cb47c276f6f796d11bdc9c8ec7ec99 by Albert Astals Cid.
Committed on 30/06/2014 at 18:17.
Pushed by aacid into branch 'master'.

Do not reset the model without need

>From reading the code i see no need to reset the model, the only think that i see the reset do is cause the view to "reset" too and the state of open/closed roots in the tree gets broken.

Used it for a few minutes and everything worked fine. Reading the code don't see why it shouldn't. I'll it use it a bit more for a few more days.

M  +0    -4    kate/filetree/katefiletreemodel.cpp

http://commits.kde.org/kate/5f24757090cb47c276f6f796d11bdc9c8ec7ec99
Comment 5 Albert Astals Cid 2014-06-30 18:21:03 UTC
Git commit c5bd55745ed68ecd48b52908c004865d01522c6c by Albert Astals Cid.
Committed on 30/06/2014 at 18:20.
Pushed by aacid into branch 'frameworks'.

Do not reset the model without need

>From reading the code i see no need to reset the model, the only think that i see the reset do is cause the view to "reset" too and the state of open/closed roots in the tree gets broken.

Used it for a few minutes and everything worked fine. Reading the code don't see why it shouldn't. I'll it use it a bit more for a few more days.

M  +0    -4    addons/filetree/katefiletreemodel.cpp

http://commits.kde.org/kate/c5bd55745ed68ecd48b52908c004865d01522c6c