Bug 332887 - make line width of the rectangle for inline note in annotations configurable
Summary: make line width of the rectangle for inline note in annotations configurable
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.19.60
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-03-31 22:37 UTC by Alin M Elena
Modified: 2016-05-04 18:04 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed Patch: Make inline annotation border width customizable (1.63 KB, patch)
2015-10-24 08:27 UTC, Sumit Sahrawat
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alin M Elena 2014-03-31 22:37:52 UTC
make width of the rectangle for inline note in annotations configurable

Reproducible: Always
Comment 1 Cédric 2014-04-07 20:42:17 UTC
I would like to also have this feature. Please consider to implement it. Thanks!!
Comment 2 Alin M Elena 2014-04-08 09:54:36 UTC
There is a gitreview for it... strange it did not appear here
https://git.reviewboard.kde.org/r/117267/
Comment 3 Christoph Feck 2014-04-21 12:47:06 UTC
Thanks for the patch, but it cannot be applied before the 4.14 release, which will be prepared during May and June. If you get no feedback until the first week of June, please add a comment (either here, or to the reviewboard).
Comment 4 ned 2015-06-03 12:32:07 UTC
You can already define the size of inline notes on creation. For resizing after creation, this appears to be the master bug: https://bugs.kde.org/show_bug.cgi?id=177778 - I don't think I can mark this as a duplicate.
Comment 5 Albert Astals Cid 2015-07-09 20:42:21 UTC
ned, this is about the width of the line of the rectangle, not about the width of the annotation itself
Comment 6 Albert Astals Cid 2015-07-09 20:43:24 UTC
For anyone that wants to tackle this junior job see Alin's patch in comment #2 and its comments
Comment 7 Sumit Sahrawat 2015-10-24 08:27:10 UTC
Created attachment 95099 [details]
Proposed Patch: Make inline annotation border width customizable

Patch created using `git diff --patch > patch.diff`.

I made it so that a two digit spin input is used for the line width, but the step size is 0.1, which allows quickly editing with one digit precision.

git.reviewboard.kde.org seems to be down, so posting here.
Comment 8 Sumit Sahrawat 2015-10-26 13:42:46 UTC
I created a gitreview for the bug here: https://git.reviewboard.kde.org/r/125801/
Comment 9 Albert Astals Cid 2015-11-24 00:11:22 UTC
Git commit 3400f76dad3be8cd87cdf1f4e32683005fa17ec0 by Albert Astals Cid, on behalf of Sumit Sahrawat.
Committed on 24/11/2015 at 00:10.
Pushed by aacid into branch 'master'.

Make inline annotation border width customizable, using a spin widget to accept input

REVIEW: 125801

M  +2    -0    conf/widgetannottools.cpp
M  +11   -0    ui/annotationwidgets.cpp
M  +1    -0    ui/annotationwidgets.h
M  +13   -6    ui/pagepainter.cpp
M  +5    -0    ui/pageviewannotator.cpp

http://commits.kde.org/okular/3400f76dad3be8cd87cdf1f4e32683005fa17ec0