Bug 332833 - Support loading kgraphviewer via KPluginFactory
Summary: Support loading kgraphviewer via KPluginFactory
Status: RESOLVED FIXED
Alias: None
Product: massif-visualizer
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: master
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 0.2
Assignee: Arnold Dumas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-31 06:02 UTC by Reimar Döffinger
Modified: 2014-04-22 21:52 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/massif-visualizer/c5a03f76e353dbff0755d72ede9fc450fc343082
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Reimar Döffinger 2014-03-31 06:02:05 UTC 
I removed use of the deprecated KLibFactory in kgraphviewer.
This basically means you have to replace
KLibFactory *factory = KLibLoader::self()->factory("kgraphviewerpart");
by
KPluginFactory *factory = KPluginLoader("kgraphviewerpart").factory();
for it to still work.
I hope that is ok, I expect it should be possible to support both in principle, but it would have been a lot of code and pain, so I'd prefer to just ask everyone to change their code.
Please contact me if you have any concerns or would like me to handle this change in a different way.

Reproducible: Always
Comment 1 Arnold Dumas 2014-04-22 21:52:59 UTC 
Git commit c5a03f76e353dbff0755d72ede9fc450fc343082 by Arnold Dumas.
Committed on 22/04/2014 at 21:45.
Pushed by arnolddumas into branch 'master'.

Support loading kgraphviewer via KPluginFactory.
REVIEW: 117375

M  +4    -4    app/documentwidget.cpp
M  +6    -4    app/mainwindow.cpp

http://commits.kde.org/massif-visualizer/c5a03f76e353dbff0755d72ede9fc450fc343082