Bug 332789 - kdesrc-build should support giving options for each build system
Summary: kdesrc-build should support giving options for each build system
Status: RESOLVED WORKSFORME
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-30 02:41 UTC by Michael Pyne
Modified: 2024-05-10 09:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pyne 2014-03-30 02:41:23 UTC
Many of the issues experienced with options like cmake-options, cxxflags, etc. are because kdesrc-build uses those options for all build systems, not just the "KDE4" one.

This makes sense historically, when there was only one build system except for qt-copy (which was always special-cased), but now that there are many other build systems (Qt4, KDE, CMake's bootstrap, autoconf...) it would probably make more sense to be able to specify build-system options for each build system. E.g. bug 331654 would be less of a problem if cmake-bootstrap would simply ignore the 'global' build system options.

The question would be what the best way to parse this would be.
Comment 1 Michael Pyne 2014-03-30 04:17:54 UTC
Git commit 9fb3fb04d170478c922c5d85bb996f8f4b7ed82c by Michael Pyne.
Committed on 30/03/2014 at 03:39.
Pushed by mpyne into branch 'master'.

build-systems: Mask default options for non-default build systems.

This is a first-step hack to have non-default build systems ignore
global options which are related to the build system in use (e.g.
compile or make flags, install/uninstall options, etc.).

This should fix bug 331654 (now that I understand it better) and improve
the situation for bug 332789 (which would be the long-term fix when
implemented).
Related: bug 331654
FIXED-IN:1.16

M  +11   -8    doc/index.docbook
M  +31   -1    modules/ksb/BuildSystem.pm

http://commits.kde.org/kdesrc-build/9fb3fb04d170478c922c5d85bb996f8f4b7ed82c
Comment 2 Andrew Crouthamel 2018-11-11 04:22:39 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Andrew Crouthamel 2018-11-21 04:34:01 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Justin Zobel 2023-01-08 22:45:13 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 5 Bug Janitor Service 2023-01-23 05:05:01 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2023-02-07 03:55:26 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 7 Michael Pyne 2024-05-10 09:16:40 UTC
Git commit bca4e917547a7b1a720b18bd4598a4ac63d5eba4 by Michael Pyne.
Committed on 30/03/2014 at 03:39.
Pushed by ashark into branch 'docbook_historied_per_file'.

build-systems: Mask default options for non-default build systems.

This is a first-step hack to have non-default build systems ignore
global options which are related to the build system in use (e.g.
compile or make flags, install/uninstall options, etc.).

This should fix bug 331654 (now that I understand it better) and improve
the situation for bug 332789 (which would be the long-term fix when
implemented).
Related: bug 331654
FIXED-IN:1.16

Original commit: 9fb3fb04
https://invent.kde.org/sdk/kdesrc-build/-/commit/9fb3fb04d170478c922c5d85bb996f8f4b7ed82c

M  +11   -8    doc/kdesrc-buildrc/conf-options-table.docbook

https://invent.kde.org/sdk/kdesrc-build/-/commit/bca4e917547a7b1a720b18bd4598a4ac63d5eba4