Bug 332718 - Collaboration diagrams do not support required message types
Summary: Collaboration diagrams do not support required message types
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.12.3
Platform: unspecified All
: NOR normal
Target Milestone: ---
Assignee: Ralf Habacker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 23:08 UTC by Ralf Habacker
Modified: 2014-06-09 19:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.13.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2014-03-27 23:08:24 UTC
uml 1.4 specifies a synchronous and asynchronous message type for collaboration type (http://www.scoberlin.de/content/media/http/informatik/uml/umlnotation.pdf)
(similar to uml 2.0 communications diagrams). According to the graphical notation (a line with an open arrow) it looks that umbrello only supports asynchronous collaboration messages 

Reproducible: Always

Steps to Reproduce:
1. open umbrello
2. add collaboration diagram
3. add 2 objects
4. connect objects 
Actual Results:  
only asynchronous messages are possible

Expected Results:  
It should be able to add synchronous messages
Comment 1 Ralf Habacker 2014-03-29 19:25:44 UTC
Git commit aa106ad7f4cdc81071ac1628b021f76a7a8b859c by Ralf Habacker.
Committed on 27/03/2014 at 22:52.
Pushed by habacker into branch 'master'.

Fix bug not displaying open arrow on collaboration messages.

This happens when the message line length is zero.

M  +3    -0    umbrello/widgets/associationline.cpp

http://commits.kde.org/umbrello/aa106ad7f4cdc81071ac1628b021f76a7a8b859c
Comment 2 Ralf Habacker 2014-03-29 22:22:18 UTC
Git commit 21bd20984110989f349fbaada27ba3faead2ab29 by Ralf Habacker.
Committed on 29/03/2014 at 21:58.
Pushed by habacker into branch 'master'.

Fix test case.

M  +6    -2    umbrello/basictypes.cpp

http://commits.kde.org/umbrello/21bd20984110989f349fbaada27ba3faead2ab29
Comment 3 Ralf Habacker 2014-03-29 22:22:20 UTC
Git commit 796a1792cb81f3bf5038b04fceaaaa191d957382 by Ralf Habacker.
Committed on 29/03/2014 at 22:16.
Pushed by habacker into branch 'master'.

Fix order of association types.

M  +3    -1    umbrello/basictypes.h

http://commits.kde.org/umbrello/796a1792cb81f3bf5038b04fceaaaa191d957382
Comment 4 Ralf Habacker 2014-03-29 23:34:19 UTC
Git commit fb7ac50f18094508efd50e00c2b9935a094ab29f by Ralf Habacker.
Committed on 29/03/2014 at 23:09.
Pushed by habacker into branch 'master'.

Do not display unsupported association types in association property page for collaboration diagrams.

M  +7    -0    umbrello/dialogs/assocgenpage.cpp

http://commits.kde.org/umbrello/fb7ac50f18094508efd50e00c2b9935a094ab29f
Comment 5 Ralf Habacker 2014-03-31 09:25:53 UTC
Git commit cf38c52844c127f858fb2d3c87ddf4751cab4a51 by Ralf Habacker.
Committed on 31/03/2014 at 09:24.
Pushed by habacker into branch 'master'.

Install new icons for collaboration messages.

M  +2    -0    umbrello/pics/CMakeLists.txt

http://commits.kde.org/umbrello/cf38c52844c127f858fb2d3c87ddf4751cab4a51
Comment 6 Ralf Habacker 2014-04-29 14:14:19 UTC
Git commit 142defbee65642b39f255ac21e4cb38ec9abf9bf by Ralf Habacker.
Committed on 27/03/2014 at 22:52.
Pushed by habacker into branch 'KDE/4.13'.

Fix bug not displaying open arrow on collaboration messages.

This happens when the message line length is zero.
(cherry picked from commit aa106ad7f4cdc81071ac1628b021f76a7a8b859c)

M  +3    -0    umbrello/widgets/associationline.cpp

http://commits.kde.org/umbrello/142defbee65642b39f255ac21e4cb38ec9abf9bf
Comment 7 Ralf Habacker 2014-04-29 14:14:20 UTC
Git commit 2953fdf66afb11b8efdbaf6d58e900fc2b520333 by Ralf Habacker.
Committed on 29/03/2014 at 10:22.
Pushed by habacker into branch 'KDE/4.13'.

Add synchronous message support to collaboration diagrams.
(cherry picked from commit 31857d900a8b42626f0ec54561717d2aabdf9c15)

M  +6    -3    umbrello/assocrules.cpp
M  +3    -3    umbrello/basictypes.cpp
M  +2    -1    umbrello/basictypes.h
M  +5    -2    umbrello/icon_utils.cpp
M  +2    -1    umbrello/icon_utils.h
A  +-    --    umbrello/pics/cursor-umbr-coll-message-asynchronous.png
A  +-    --    umbrello/pics/cursor-umbr-coll-message-synchronous.png
A  +641  -0    umbrello/pics/sources/cursor-umbr-coll-message-asynchronous.svg
A  +712  -0    umbrello/pics/sources/cursor-umbr-coll-message-synchronous.svg
A  +172  -0    umbrello/pics/sources/umbr-coll-message-asynchronous.svg
A  +172  -0    umbrello/pics/sources/umbr-coll-message-synchronous.svg
A  +-    --    umbrello/pics/umbr-coll-message-asynchronous.png
A  +-    --    umbrello/pics/umbr-coll-message-synchronous.png
M  +2    -1    umbrello/toolbarstateassociation.cpp
M  +2    -1    umbrello/toolbarstatefactory.cpp
M  +8    -2    umbrello/widgets/associationline.cpp
M  +3    -1    umbrello/widgets/associationwidget.cpp
M  +6    -3    umbrello/worktoolbar.cpp
M  +4    -2    umbrello/worktoolbar.h

http://commits.kde.org/umbrello/2953fdf66afb11b8efdbaf6d58e900fc2b520333
Comment 8 Ralf Habacker 2014-04-29 14:14:22 UTC
Git commit 70f022081c9831c4d46c210cb4b5f292ff740e91 by Ralf Habacker.
Committed on 29/03/2014 at 21:58.
Pushed by habacker into branch 'KDE/4.13'.

Fix test case.
(cherry picked from commit 21bd20984110989f349fbaada27ba3faead2ab29)

M  +6    -2    umbrello/basictypes.cpp

http://commits.kde.org/umbrello/70f022081c9831c4d46c210cb4b5f292ff740e91
Comment 9 Ralf Habacker 2014-04-29 14:14:23 UTC
Git commit d49925f5bc03947d19088929c363f4a871819f67 by Ralf Habacker.
Committed on 29/03/2014 at 22:16.
Pushed by habacker into branch 'KDE/4.13'.

Fix order of association types.
(cherry picked from commit 796a1792cb81f3bf5038b04fceaaaa191d957382)

M  +3    -1    umbrello/basictypes.h

http://commits.kde.org/umbrello/d49925f5bc03947d19088929c363f4a871819f67
Comment 10 Ralf Habacker 2014-04-29 14:40:22 UTC
Git commit 8397c1cf8f83c47ab70649dbf440f6203c8272e6 by Ralf Habacker.
Committed on 31/03/2014 at 09:24.
Pushed by habacker into branch 'KDE/4.13'.

Install new icons for collaboration messages.

(cherry picked from commit cf38c52844c127f858fb2d3c87ddf4751cab4a51)

M  +2    -0    umbrello/pics/CMakeLists.txt

http://commits.kde.org/umbrello/8397c1cf8f83c47ab70649dbf440f6203c8272e6
Comment 11 Ralf Habacker 2014-04-29 14:40:33 UTC
Git commit 2c2b5d358a513f7ed1370410408497865a0527dd by Ralf Habacker.
Committed on 29/03/2014 at 23:09.
Pushed by habacker into branch 'KDE/4.13'.

Do not display unsupported association types in association property page for collaboration diagrams.
(cherry picked from commit fb7ac50f18094508efd50e00c2b9935a094ab29f)

M  +7    -0    umbrello/dialogs/assocgenpage.cpp

http://commits.kde.org/umbrello/2c2b5d358a513f7ed1370410408497865a0527dd