Bug 332663 - Wrong location of documentation translations
Summary: Wrong location of documentation translations
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Documentation (show other bugs)
Version: 4.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 01:36 UTC by nucleo
Modified: 2017-07-11 10:04 UTC (History)
6 users (show)

See Also:
Latest Commit: http://commits.kde.org/scratch/mwiesweg/digikam-sc/7b15383080188c8ceff1c4af0cbbb2f046578b73
Version Fixed In: 4.0.0

Attachments
location fix (2.60 KB, patch)
2014-03-27 02:36 UTC, nucleo 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description nucleo 2014-03-27 01:36:46 UTC 
Some of files installed in wrong locations in digikam-4.0.0-beta4:

   /usr/share/doc/HTML/et/et/color-management.docbook
   /usr/share/doc/HTML/et/et/common
   /usr/share/doc/HTML/et/et/credits-annex.docbook
   /usr/share/doc/HTML/et/et/editor-color.docbook
   /usr/share/doc/HTML/et/et/editor-decorate.docbook
   /usr/share/doc/HTML/et/et/editor-enhance.docbook
   /usr/share/doc/HTML/et/et/editor-filters.docbook
   /usr/share/doc/HTML/et/et/editor-transform.docbook
   /usr/share/doc/HTML/et/et/file-formats.docbook
   /usr/share/doc/HTML/et/et/ie-menu.docbook
   /usr/share/doc/HTML/et/et/index.cache.bz2
   /usr/share/doc/HTML/et/et/index.docbook
   /usr/share/doc/HTML/et/et/menu-descriptions.docbook
   /usr/share/doc/HTML/et/et/photo-editing.docbook
   /usr/share/doc/HTML/et/et/sidebar.docbook
   /usr/share/doc/HTML/it/it/color-management.docbook
   /usr/share/doc/HTML/it/it/common
   /usr/share/doc/HTML/it/it/credits-annex.docbook
   /usr/share/doc/HTML/it/it/editor-color.docbook
   /usr/share/doc/HTML/it/it/editor-decorate.docbook
   /usr/share/doc/HTML/it/it/editor-enhance.docbook
   /usr/share/doc/HTML/it/it/editor-filters.docbook
   /usr/share/doc/HTML/it/it/editor-transform.docbook
   /usr/share/doc/HTML/it/it/file-formats.docbook
   /usr/share/doc/HTML/it/it/ie-menu.docbook
   /usr/share/doc/HTML/it/it/index.cache.bz2
   /usr/share/doc/HTML/it/it/index.docbook
   /usr/share/doc/HTML/it/it/menu-descriptions.docbook
   /usr/share/doc/HTML/it/it/photo-editing.docbook
   /usr/share/doc/HTML/it/it/sidebar.docbook
   /usr/share/doc/HTML/nl/nl/color-management.docbook
   /usr/share/doc/HTML/nl/nl/common
   /usr/share/doc/HTML/nl/nl/credits-annex.docbook
   /usr/share/doc/HTML/nl/nl/editor-color.docbook
   /usr/share/doc/HTML/nl/nl/editor-decorate.docbook
   /usr/share/doc/HTML/nl/nl/editor-enhance.docbook
   /usr/share/doc/HTML/nl/nl/editor-filters.docbook
   /usr/share/doc/HTML/nl/nl/editor-transform.docbook
   /usr/share/doc/HTML/nl/nl/file-formats.docbook
   /usr/share/doc/HTML/nl/nl/ie-menu.docbook
   /usr/share/doc/HTML/nl/nl/index.cache.bz2
   /usr/share/doc/HTML/nl/nl/index.docbook
   /usr/share/doc/HTML/nl/nl/menu-descriptions.docbook
   /usr/share/doc/HTML/nl/nl/photo-editing.docbook
   /usr/share/doc/HTML/nl/nl/sidebar.docbook
   /usr/share/doc/HTML/pt/pt/color-management.docbook
   /usr/share/doc/HTML/pt/pt/common
   /usr/share/doc/HTML/pt/pt/credits-annex.docbook
   /usr/share/doc/HTML/pt/pt/editor-color.docbook
   /usr/share/doc/HTML/pt/pt/editor-decorate.docbook
   /usr/share/doc/HTML/pt/pt/editor-enhance.docbook
   /usr/share/doc/HTML/pt/pt/editor-filters.docbook
   /usr/share/doc/HTML/pt/pt/editor-transform.docbook
   /usr/share/doc/HTML/pt/pt/file-formats.docbook
   /usr/share/doc/HTML/pt/pt/ie-menu.docbook
   /usr/share/doc/HTML/pt/pt/index.cache.bz2
   /usr/share/doc/HTML/pt/pt/index.docbook
   /usr/share/doc/HTML/pt/pt/menu-descriptions.docbook
   /usr/share/doc/HTML/pt/pt/photo-editing.docbook
   /usr/share/doc/HTML/pt/pt/sidebar.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/color-management.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/common
   /usr/share/doc/HTML/pt_BR/pt_BR/credits-annex.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-color.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-decorate.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-enhance.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-filters.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-transform.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/file-formats.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/ie-menu.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/index.cache.bz2
   /usr/share/doc/HTML/pt_BR/pt_BR/index.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/menu-descriptions.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/photo-editing.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/sidebar.docbook
   /usr/share/doc/HTML/sv/sv/color-management.docbook
   /usr/share/doc/HTML/sv/sv/common
   /usr/share/doc/HTML/sv/sv/credits-annex.docbook
   /usr/share/doc/HTML/sv/sv/editor-color.docbook
   /usr/share/doc/HTML/sv/sv/editor-decorate.docbook
   /usr/share/doc/HTML/sv/sv/editor-enhance.docbook
   /usr/share/doc/HTML/sv/sv/editor-filters.docbook
   /usr/share/doc/HTML/sv/sv/editor-transform.docbook
   /usr/share/doc/HTML/sv/sv/file-formats.docbook
   /usr/share/doc/HTML/sv/sv/ie-menu.docbook
   /usr/share/doc/HTML/sv/sv/index.cache.bz2
   /usr/share/doc/HTML/sv/sv/index.docbook
   /usr/share/doc/HTML/sv/sv/menu-descriptions.docbook
   /usr/share/doc/HTML/sv/sv/photo-editing.docbook
   /usr/share/doc/HTML/sv/sv/sidebar.docbook
   /usr/share/doc/HTML/uk/uk/color-management.docbook
   /usr/share/doc/HTML/uk/uk/common
   /usr/share/doc/HTML/uk/uk/credits-annex.docbook
   /usr/share/doc/HTML/uk/uk/editor-color.docbook
   /usr/share/doc/HTML/uk/uk/editor-decorate.docbook
   /usr/share/doc/HTML/uk/uk/editor-enhance.docbook
   /usr/share/doc/HTML/uk/uk/editor-filters.docbook
   /usr/share/doc/HTML/uk/uk/editor-transform.docbook
   /usr/share/doc/HTML/uk/uk/file-formats.docbook
   /usr/share/doc/HTML/uk/uk/ie-menu.docbook
   /usr/share/doc/HTML/uk/uk/index.cache.bz2
   /usr/share/doc/HTML/uk/uk/index.docbook
   /usr/share/doc/HTML/uk/uk/menu-descriptions.docbook
   /usr/share/doc/HTML/uk/uk/photo-editing.docbook
   /usr/share/doc/HTML/uk/uk/sidebar.docbook

Reproducible: Always



Expected Results:  
Right location should be such as 
/usr/share/doc/HTML/en/digikam/color-management.docbook
Comment 1 Kevin Kofler 2014-03-27 01:46:28 UTC 
doc-translated/*/CMakeLists.txt has:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/ )
That should be:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/ SUBDIR digikam )
(of course, replace "et" by the respective language.)

(SUBDIR is required whenever the directory name in the tarball does not match the target directory name, i.e. typically for translated documentation.)
Comment 2 nucleo 2014-03-27 02:36:15 UTC 
Created attachment 85779 [details]
location fix

Patch made from Comment 1.
Comment 3 nucleo 2014-03-27 02:37:13 UTC 
doc-translated subdir is new in beta4 tarball, it wasn't in beta3.
Comment 4 caulier.gilles 2014-03-27 08:30:04 UTC 
Nicolas,

Do you see this entry ?

Gilles Caulier
Comment 5 Pino Toscano 2014-03-30 19:27:38 UTC 
(In reply to comment #2)
> Created attachment 85779 [details]
> location fix
> 
> Patch made from Comment 1.

While the approach is correct, the patch is wrong since those files are autogenerated by a script in the digikam-software-compilation repository (project/release/fetch_l10n.rb).
I am going to fix it properly now.
Comment 6 Pino Toscano 2014-03-30 19:32:07 UTC 
Git commit 7b15383080188c8ceff1c4af0cbbb2f046578b73 by Pino Toscano.
Committed on 30/03/2014 at 19:31.
Pushed by pino into branch 'master'.

fetch_l10n.rb: fix creation of CMakeLists.txt for doc translations

M  +1    -1    project/release/fetch_l10n.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/7b15383080188c8ceff1c4af0cbbb2f046578b73
Comment 7 Kevin Kofler 2014-03-30 20:05:19 UTC 
Well, nucleo's patch fixed your release tarball. :-) But thanks for the fix to the script that generates your release files. :-)
Comment 8 Pino Toscano 2014-03-30 20:08:59 UTC 
(In reply to comment #7)
> Well, nucleo's patch fixed your release tarball. :-)

Yes, I know what the patch does.

> But thanks for the fix to the script that generates your release files. :-)

Please drop the "your", since I'm not a digikam developer.
Comment 9 Nicolas L. 2014-04-01 12:23:45 UTC 
thanks, we will have this fixed for rc then, or do i need to respin the tarball ? ( like a beta4.1 tarball )
Comment 10 caulier.gilles 2014-04-01 12:25:12 UTC 
@Nivolas,

No need, 4.0.0-RC is planed in 2 weeks.

Gilles