Activate Next Tab / Activate Previous Tab
Wordy: no need for word "Activate". User can re-word them himself but the default should fit on toolbars better.
Thanks for the report. This text is not Dolphin-specific. It comes from
kstandardshortcut.cpp in kdelibs/kdeui.
This is about the action texts, not the keyboard shortcuts. dolphinmainwindow.cpp::1635 says:
KAction* activateNextTab = actionCollection()->addAction("activate_next_tab");
activateNextTab->setText(i18nc("@action:inmenu", "Activate Next Tab"));
I suggest to setIconText() a shorter version of the string for the tool bar in addition to setText() the longer version for the menu.
Thanks for the info and sorry for the mistake, Christoph. I first thought that the text is picked up by applications from kstandardshortcut.cpp, where I quickly found it, but you are right, of course.
(In reply to comment #2)
> I suggest to setIconText() a shorter version of the string for the tool bar
> in addition to setText() the longer version for the menu.
Yes, good idea. This looks like it could be a good Junior Job for potential new contributors.
Created attachment 85876 [details]
correct the action caption
This patch removes "Activate" from the action "Previous Tab" and "Next Tab".
Thanks for the patch, looks good! :)
Can you please adjust your patch so that it uses the long text in the menu and the short text in the toolbar? - See comment #2 for additional information.
And then you can post your patch on reviewboard http://git.reviewboard.kde.org - example review request https://git.reviewboard.kde.org/r/117209/ - or just upload your new patch here ;)
I'm attaching a diff with the proposed solution. I'm going to create a review request, but I'd like to know first if icons are desired for these actions.
I tried to find the left and right arrows used on QTabBar but it is linked to QToolButton. Would something like this be useful (or any other icons):
Probably using QApplication::isRightToLeft() to determine the arrow direction.
Created attachment 86270 [details]
proposed solution (comment #2)
Well, I've submitted a review request strictly with the expected change.
Git commit 03f7f20b9ffa3cd1b9e090b191630888a6a0f99c by Frank Reininghaus, on behalf of Renato Atilio.
Committed on 29/04/2014 at 19:54.
Pushed by freininghaus into branch 'master'.
Change the icon text for Previous and Next toolbar buttons
In addition to the current long text for previous and next toolbar
buttons ("Activate Previous/Next Tab"), this commit adds shorter icon
texts for them to be used only on the toolbar ("Previous/Next Tab").
M +2 -0 dolphin/src/dolphinmainwindow.cpp