Bug 332578 - superfluous x-test language
Summary: superfluous x-test language
Status: RESOLVED FIXED
Alias: None
Product: trojita
Classification: Applications
Component: Core (show other bugs)
Version: 0.4.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 11:48 UTC by kavol
Modified: 2014-04-09 07:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kavol 2014-03-25 11:48:49 UTC
I have noticed that Trojitá installs and provides 'x-test' language. This should be hidden from the user. Or maybe completely removed, as it is not needed for build, neither for the testsuite ...?

Reproducible: Always
Comment 1 Jan Kundrát 2014-03-25 12:45:20 UTC
Looks like an issue with the way we prepare a release tarball, thanks. I suppose KDE has some reason on why they use that file during development, though.
Comment 2 Thomas Lübking 2014-03-25 12:49:18 UTC
Those are added the i18n scripts on the KDE git server.
http://techbase.kde.org/Development/Tools#Internationalization_.28i18n.29_Tools
Comment 3 kavol 2014-03-25 13:09:59 UTC
well, interesting ... so, probably this should be kept when doing debug build and removed when doing release
Comment 4 Jan Kundrát 2014-04-07 16:12:19 UTC
Patch under review at https://git.reviewboard.kde.org/r/117423/
Comment 5 Jan Kundrát 2014-04-08 18:57:29 UTC
Git commit a13982a81646658930353464576422425aadfb8b by Jan Kundrát.
Committed on 07/04/2014 at 15:47.
Pushed by jkt into branch 'master'.

Remove the x-test language from the .desktop files

In cmake, this is not just a matter of running `grep -v`, unfortunately.

The regexp contains the trailing LF because otherwise I cannot ask it to remove
that line instead of insisting on replacing it with an empty one.

M  +6    -2    CMakeLists.txt
A  +5    -0    cmake/SanitizedDesktopFile.cmake

http://commits.kde.org/trojita/a13982a81646658930353464576422425aadfb8b
Comment 6 Jan Kundrát 2014-04-08 18:57:30 UTC
Git commit 1bd47ac9545e0f682a9a055ebeda7afc7eed65ab by Jan Kundrát.
Committed on 07/04/2014 at 16:05.
Pushed by jkt into branch 'master'.

Do not install the x-test translations

The .qm files should still be produced when doing the build (especially the
debug one), but there is no need to install them to the users' systems.

M  +1    -1    CMakeLists.txt

http://commits.kde.org/trojita/1bd47ac9545e0f682a9a055ebeda7afc7eed65ab
Comment 7 kavol 2014-04-09 07:43:28 UTC
cool, thanks!